Closed
Bug 2094991
Opened 3 days ago
Closed 2 days ago
Remove the unused `FenixDialogFragment` from Fenix
Categories
(Firefox for Android :: General, task, P3)
Tracking
()
RESOLVED
FIXED
163 Branch
| Tracking | Status | |
|---|---|---|
| firefox163 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
Details
(Whiteboard: [fxdroid] [group5])
Attachments
(1 external file)
FenixDialogFragment is an abstract base class for top and bottom dialogs that no longer has any subclasses in production code or tests.
Its last subclass, the Quick Settings sheet, was removed in bug 2048435 Part 4 ("Remove the Quick Settings sheet") after the Unified Trust Panel was enabled by default. The base class was left in place.
Steps:
- Delete
FenixDialogFragment.kt - Remove its detekt baseline entry
Updated•3 days ago
|
| Assignee | ||
Comment 1•3 days ago
|
||
- Last subclass removed with the Quick Settings sheet in bug 2048435
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/61642cf813d6
https://hg.mozilla.org/integration/autoland/rev/53bfeb2f9456
Remove the unused `FenixDialogFragment` from Fenix r=android-reviewers,Roger
Comment 3•2 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 days ago
status-firefox163:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 163 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•