Closed
Bug 2049029
Opened 5 months ago
Closed 13 days ago
Cleanup all code related to the old "More from Mozilla" pane in about:preferences
Categories
(Firefox :: Settings UI, task, P3)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: hjones, Assigned: tgiles)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [recomp])
Attachments
(1 external file)
Once we are confident all the new More from Mozilla pane is working as expected / the SRD pref has been flipped for a while we should go back and cleanup all the unused code related to the old page. Specifically we should:
- delete
browser/components/preferences/moreFromMozilla.jsand cleanup any references - delete
browser/components/preferences/moreFromMozilla.inc.xhtmland cleanup any references- check to see if there are any CSS styles, images, or other assets that are specific to that xhtml file and delete them
- check to see if there are any Fluent ID that will be completely unused after we remove this markup/JS code and delete them
- remove any references to
gMoreFromMozillaPane
| Reporter | ||
Updated•5 months ago
|
Whiteboard: [recomp]
Updated•5 months ago
|
| Assignee | ||
Updated•1 month ago
|
Assignee: nobody → tgiles
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•1 month ago
|
||
Remove the legacy controller, markup, styles, strings, images, and
tests. Retain the config-based redesigned pane and its shared navigation
and resources.
Consolidate the redesigned tests in browser.toml and remove the legacy
helper branch.
Keep the existing redesign gate. Requests for the removed pane fall back
to General when redesign is disabled, or Sync when redesign is enabled
but More from Mozilla is disabled. Add coverage for both cases.
| Assignee | ||
Updated•1 month ago
|
Severity: -- → N/A
Priority: -- → P3
| Assignee | ||
Updated•1 month ago
|
Pushed by tgiles@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5ba6a496d5d8
https://hg.mozilla.org/integration/autoland/rev/a148ca192545
Remove old "More from Mozilla" code. r=settings-reviewers,desktop-theme-reviewers,mkennedy,mstriemer
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•