Closed Bug 2049029 Opened 5 months ago Closed 13 days ago

Cleanup all code related to the old "More from Mozilla" pane in about:preferences

Categories

(Firefox :: Settings UI, task, P3)

task

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: hjones, Assigned: tgiles)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [recomp])

Attachments

(1 external file)

Once we are confident all the new More from Mozilla pane is working as expected / the SRD pref has been flipped for a while we should go back and cleanup all the unused code related to the old page. Specifically we should:

  • delete browser/components/preferences/moreFromMozilla.js and cleanup any references
  • delete browser/components/preferences/moreFromMozilla.inc.xhtml and cleanup any references
    • check to see if there are any CSS styles, images, or other assets that are specific to that xhtml file and delete them
    • check to see if there are any Fluent ID that will be completely unused after we remove this markup/JS code and delete them
  • remove any references to gMoreFromMozillaPane
Whiteboard: [recomp]
Assignee: nobody → tgiles
Status: NEW → ASSIGNED

Remove the legacy controller, markup, styles, strings, images, and
tests. Retain the config-based redesigned pane and its shared navigation
and resources.

Consolidate the redesigned tests in browser.toml and remove the legacy
helper branch.

Keep the existing redesign gate. Requests for the removed pane fall back
to General when redesign is disabled, or Sync when redesign is enabled
but More from Mozilla is disabled. Add coverage for both cases.

Severity: -- → N/A
Priority: -- → P3
Depends on: 2076862, 2081814
Depends on: 2085129
Blocks: 2090273
Pushed by tgiles@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5ba6a496d5d8 https://hg.mozilla.org/integration/autoland/rev/a148ca192545 Remove old "More from Mozilla" code. r=settings-reviewers,desktop-theme-reviewers,mkennedy,mstriemer
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: