Closed Bug 2081814 Opened 1 month ago Closed 29 days ago

Cleanup all tests that rely on the browser.settings-redesign.enabled pref being set to false

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(18 external files)

In order to be able to lock the SRD pref in Bug 2076862 we first need to clean up any / all test code that relies on the pref being set to false, since it will no longer be possible to override the value once it's locked.

We need to:

  • Go through every folder in browser/components/preferences/tests/
    • remove the browser.toml files as well as any tests that are only running in that file i.e. against the old UI (in some cases we have duplicate sets of tests where the old test files end in _xul)
    • rename the browser-srd.toml files to browser.toml (we can also remove the lines in these files that are explicitly setting the pref to true, since that will be the default value once it's locked)
    • go through the remaining test files in the folder and remove any checks for browser.settings-redesign.enabled, as well as any logic for when the pref is set to false
  • repeat these steps for any tests that don't live in a folder but are under browser/components/preferences/tests/
  • there may be some extraneous browser/components/preferences/tests/ checks in test files outside of preferences - we should do a quick search and remove these too

This work should naturally lend itself to being done in a stack of patches.

Blocks: 2049029
Assignee: nobody → hjones
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8041c8b8b195 https://hg.mozilla.org/integration/autoland/rev/0ff45250e73f cleanup aiFeatures tests that rely on SRD pref being unset r=akulyk https://github.com/mozilla-firefox/firefox/commit/d754da38c7dc https://hg.mozilla.org/integration/autoland/rev/95a95539437a cleanup applications tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/8e8bf593b804 https://hg.mozilla.org/integration/autoland/rev/d24b60148707 cleanup credentials tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/dfb128d24c65 https://hg.mozilla.org/integration/autoland/rev/dbf7518124b8 cleanup etp tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/f29907b41908 https://hg.mozilla.org/integration/autoland/rev/f67d11ce0378 cleanup experimental_features tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/2f79946d7b62 https://hg.mozilla.org/integration/autoland/rev/18435b35c5a1 cleanup languages tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/b9a1a8685e44 https://hg.mozilla.org/integration/autoland/rev/b6223cf72b0d cleanup moreFromMozilla tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/8459dbf0b328 https://hg.mozilla.org/integration/autoland/rev/5a683f990439 cleanup networking tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/18fe98dc0489 https://hg.mozilla.org/integration/autoland/rev/e40eee0ffab5 cleanup performance tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/179d58711812 https://hg.mozilla.org/integration/autoland/rev/3f0a829d891d cleanup permissions tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/285f1281c80c https://hg.mozilla.org/integration/autoland/rev/8b5591bb375c cleanup privacy tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/fc9b485f6edf https://hg.mozilla.org/integration/autoland/rev/d712473e3b75 cleanup search tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/f7630e5764e3 https://hg.mozilla.org/integration/autoland/rev/ae3a4b779ac4 cleanup searchResults tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/73ccc357fa70 https://hg.mozilla.org/integration/autoland/rev/a28f108eefa8 cleanup security tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/a82f47fa15ed https://hg.mozilla.org/integration/autoland/rev/20cdf5fb0ad9 cleanup siteData tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/35cc6db1aad1 https://hg.mozilla.org/integration/autoland/rev/cf3d7b93b81f cleanup sync tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/b7816bdeb362 https://hg.mozilla.org/integration/autoland/rev/fd65ea4f2303 cleanup telemetry tests that rely on SRD pref being unset r=settings-reviewers,akulyk https://github.com/mozilla-firefox/firefox/commit/d6fd7a4e69b3 https://hg.mozilla.org/integration/autoland/rev/006163118837 cleanup remaining preferences tests that rely on SRD pref being unset r=settings-reviewers,akulyk
Regressions: 2084926
QA Whiteboard: [qa-triage-done-c161/b160]
Duplicate of this bug: 2078667
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: