Cleanup all tests that rely on the browser.settings-redesign.enabled pref being set to false
Categories
(Firefox :: Settings UI, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(18 external files)
In order to be able to lock the SRD pref in Bug 2076862 we first need to clean up any / all test code that relies on the pref being set to false, since it will no longer be possible to override the value once it's locked.
We need to:
- Go through every folder in
browser/components/preferences/tests/- remove the
browser.tomlfiles as well as any tests that are only running in that file i.e. against the old UI (in some cases we have duplicate sets of tests where the old test files end in_xul) - rename the
browser-srd.tomlfiles tobrowser.toml(we can also remove the lines in these files that are explicitly setting the pref totrue, since that will be the default value once it's locked) - go through the remaining test files in the folder and remove any checks for
browser.settings-redesign.enabled, as well as any logic for when the pref is set tofalse
- remove the
- repeat these steps for any tests that don't live in a folder but are under
browser/components/preferences/tests/ - there may be some extraneous
browser/components/preferences/tests/checks in test files outside ofpreferences- we should do a quick search and remove these too
This work should naturally lend itself to being done in a stack of patches.
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
|
||
| Assignee | ||
Comment 4•1 month ago
|
||
| Assignee | ||
Comment 5•1 month ago
|
||
| Assignee | ||
Comment 6•1 month ago
|
||
| Assignee | ||
Comment 7•1 month ago
|
||
| Assignee | ||
Comment 8•1 month ago
|
||
| Assignee | ||
Comment 9•1 month ago
|
||
| Assignee | ||
Comment 10•1 month ago
|
||
| Assignee | ||
Comment 11•1 month ago
|
||
| Assignee | ||
Comment 12•1 month ago
|
||
| Assignee | ||
Comment 13•1 month ago
|
||
| Assignee | ||
Comment 14•1 month ago
|
||
| Assignee | ||
Comment 15•1 month ago
|
||
| Assignee | ||
Comment 16•1 month ago
|
||
| Assignee | ||
Comment 17•1 month ago
|
||
| Assignee | ||
Comment 18•1 month ago
|
||
Comment 19•29 days ago
|
||
Comment 20•29 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0ff45250e73f
https://hg.mozilla.org/mozilla-central/rev/95a95539437a
https://hg.mozilla.org/mozilla-central/rev/d24b60148707
https://hg.mozilla.org/mozilla-central/rev/dbf7518124b8
https://hg.mozilla.org/mozilla-central/rev/f67d11ce0378
https://hg.mozilla.org/mozilla-central/rev/18435b35c5a1
https://hg.mozilla.org/mozilla-central/rev/b6223cf72b0d
https://hg.mozilla.org/mozilla-central/rev/5a683f990439
https://hg.mozilla.org/mozilla-central/rev/e40eee0ffab5
https://hg.mozilla.org/mozilla-central/rev/3f0a829d891d
https://hg.mozilla.org/mozilla-central/rev/8b5591bb375c
https://hg.mozilla.org/mozilla-central/rev/d712473e3b75
https://hg.mozilla.org/mozilla-central/rev/ae3a4b779ac4
https://hg.mozilla.org/mozilla-central/rev/a28f108eefa8
https://hg.mozilla.org/mozilla-central/rev/20cdf5fb0ad9
https://hg.mozilla.org/mozilla-central/rev/cf3d7b93b81f
https://hg.mozilla.org/mozilla-central/rev/fd65ea4f2303
https://hg.mozilla.org/mozilla-central/rev/006163118837
Updated•22 days ago
|
Description
•