Closed
Bug 2049030
Opened 5 months ago
Closed 14 days ago
Cleanup all code related to the old "Search" pane in about:preferences
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: hjones, Assigned: akulyk)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(1 external file)
Once we are confident all the new Search settings are working as expected / the SRD pref has been flipped for a while we should go back and cleanup all the unused code related to the old pane. Specifically we should:
- delete
browser/components/preferences/search.jsand cleanup any references - delete
browser/components/preferences/search.inc.xhtmland cleanup any references- check to see if there are any CSS styles, images, or other assets that are specific to that xhtml file and delete them
- check to see if there are any Fluent ID that will be completely unused after we remove this markup/JS code and delete them
- remove any references to
gSearchPane
Updated•5 months ago
|
Comment 1•4 months ago
|
||
This is very similar to bug 2022398. Should we dupe, or just link these together?
Flags: needinfo?(hjones)
See Also: → 2022398
| Reporter | ||
Comment 2•4 months ago
|
||
Ah sorry for the delay! I think it's ok to leave both open for now just to make sure we cover all our bases. If this work ends up getting covered by the scope of that other bug we can just close both at the same time (or dupe this one at that point)
Flags: needinfo?(hjones)
Pushed by akulyk@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/41bac014df92
https://hg.mozilla.org/integration/autoland/rev/7a908e4aeaa5
Cleanup all code related to the old "Search" pane in about:preferences r=settings-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,scunnane,flod
Comment 6•14 days ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 14 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•