2049194 - Message Filters "Run Now" button stays permanently disabled

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

The "Run Now" button in the Message Filters dialog can become permanently disabled. This happens not only after clicking "Run Now", but even from an unrelated background mail poll occurring while the dialog is open — because FeedbackService broadcasts start-meteors/stop-meteors via postMessage to all windows, and the filter dialog's message listener unconditionally disables the button on any start-meteors.

Root cause: In FilterListDialog.js, the old gStatusFeedback object's stopMeteors() method re-enabled the button. When this was replaced with a window.addEventListener("message", ...) handler in D286115, the gRunFiltersButton.disabled = false line was (presumably) accidentally commented out, while the start-meteors path still correctly disables it. Once disabled, the button is never re-enabled.

Steps to reproduce:

Open Message Filters dialog (Tools > Message Filters)
Either click "Run Now", or simply wait for an automatic background mail check to occur
The "Run Now" button becomes and stays greyed out

Workaround: Close and reopen the Message Filters dialog.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2049194 - Fix "Run Now" button permanently disabled in filter dialog. r=#thunderbird-reviewers

Uncomment gRunFiltersButton.disabled = false which was accidentally
commented out when replacing nsIMsgStatusFeedback with postMessage-based
FeedbackService in bug 1985780. The start-meteors handler disables the
button, but the corresponding stop-meteors handler never re-enabled it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/14a947b0129f
Fix "Run Now" button permanently disabled in filter dialog. r=mkmelin

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9599621 [details]
Bug 2049194 - Fix "Run Now" button permanently disabled in filter dialog. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression in the 150 cycle.
• User impact if declined: User might not be able to manually run filters.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined and simple change.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 4

[Corey Bryant]

Comment on attachment 9599621 [details]
Bug 2049194 - Fix "Run Now" button permanently disabled in filter dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Evandro Baginski [:ebaginski]]

Thunderbird 153.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/cbfe10576107