2049331 - Tracking Protection is not deactivated for private window.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Monica Chiorean]

Found in

• version: 154.0a1

Affected versions

• versions: 154.0a1, 152.0.2, 153.0b3

Tested platforms

• Affected platforms: Windows
• Unaffected platforms:

Steps to reproduce

1. Access the about:preferences#privacy page with a new profile.
2. Click the "Custom" radio button from the "Enhanced Tracking Protection".
3. Uncheck the "Tracking content" checkbox.
4. Uncheck the "Cookies" checkbox.
5. Uncheck "Cyrptominers" and "Known Fingerprinters"
6. Open a new private browsing session.
7. Access the following website http://edition.cnn.com/
8. Click on the shield icon from the URL bar.
9. Click "See All" button and the "Tracking Content" button from the Protection Panel.

Expected result
*The list of all page trackers is displayed.
The trackers are not blocked.

Actual result
*The shield icon is displayed near the address bar, with a blue outline. Tracking Content is displayed with a "Blocked" status.

Regression range
*Most probably a regression as this was fixed on bug 1830054. Will check for a regression.

Comment 1

[Emma Zühlcke [:emz]]

I've submitted a patch which restores the old designs behavior. In the future we should consider adding a separate option for email tracking protection. Now that the controls are in a subview we have enough space for that.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 2049331 - Disable email tracking protection from the redesigned ETP Custom UI. r=#anti-tracking!

The old ETP Custom UI couples the email tracking protection prefs to the
tracking protection checkbox and scope menu, since email tracking
protection is surfaced through the same Tracking Content UI on the
protections panel. The settings redesign reimplemented these controls but
never wrote the email tracking prefs, so disabling Tracking Content no
longer disabled email tracking protection in private windows, reintroducing
bug 1830054.

Make the redesigned etpCustomTrackingProtectionEnabled toggle and
etpCustomTrackingProtectionEnabledContext scope settings write the email
tracking prefs alongside the tracking protection prefs, mirroring the old
design's behavior.

The original testDisableTPCheckBoxDisablesEmailTP guard only runs against
the old design; extend the redesign's test_custom_tracking_protection_controls
to cover the email tracking prefs.

Comment 3

[Monica Chiorean]

Found this regression with mozregression: Bug 2028609 - Enable Settings Redesign by default r=mkennedy

Differential Revision: https://phabricator.services.mozilla.com/D300475
app_name: firefox
build_date: 2026-05-20 00:49:13.115000
build_file: C:\Users\svuser_1.mozilla\mozregression\persist\bc28a06bdf66-pgo--autoland--target.zip
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cXZrSCXqQK-lPc0yNOzk7A/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: bc28a06bdf6655e83439071d5b19e67959ce9ff1
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2f4fc3b89031e3ac63ced28637c41aa30eaab588&tochange=bc28a06bdf6655e83439071d5b19e67959ce9ff1
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: cXZrSCXqQK-lPc0yNOzk7A

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #3, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:emz, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2028609

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d4c3b6dfaeb
https://hg.mozilla.org/integration/autoland/rev/a4b829577ee2
Disable email tracking protection from the redesigned ETP Custom UI. r=bvandersloot,mstriemer

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a4b829577ee2

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emz, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emma Zühlcke [:emz]]

Created an uplift request. I'm a bit on the fence whether this needs one, but given the current beta is ESR it's probably worth doing. If deemed to late in the beta cycle we can also uplift it at a later point into ESR.

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users can't disable email tracking protection via ETP custom settings. Workaround: disable via about:config. Users who have email tracking protection disabled already that don't interact with the settings controls should not be affected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: Small changes to the ETP custom settings logic.
• String changes made/needed?: no
• Is Android affected?: no

Comment 11

[Emma Zühlcke [:emz]]

Attachment: Bug 2049331 - Disable email tracking protection from the redesigned ETP Custom UI.

The old ETP Custom UI couples the email tracking protection prefs to the
tracking protection checkbox and scope menu, since email tracking
protection is surfaced through the same Tracking Content UI on the
protections panel. The settings redesign reimplemented these controls but
never wrote the email tracking prefs, so disabling Tracking Content no
longer disabled email tracking protection in private windows, reintroducing
bug 1830054.

Make the redesigned etpCustomTrackingProtectionEnabled toggle and
etpCustomTrackingProtectionEnabledContext scope settings write the email
tracking prefs alongside the tracking protection prefs, mirroring the old
design's behavior.

The original testDisableTPCheckBoxDisablesEmailTP guard only runs against
the old design; extend the redesign's test_custom_tracking_protection_controls
to cover the email tracking prefs.

Original Revision: https://phabricator.services.mozilla.com/D308079

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/395546f8e31e
https://hg.mozilla.org/releases/mozilla-beta/rev/6d4ecc456460

Comment 13

[Monica Chiorean]

Verified issue as fixed on Win11x64 / Mac 15.5 / Ubuntu 24.04 using FF build 154.0a1(20260707211043).
Pending verification on next beta build.

Comment 14

[Donal Meehan [:dmeehan]]

:emz, do you want to request a release uplift for the last dot release

Comment 15

[Emma Zühlcke [:emz]]

hmm I don't think this needs to be in the dot release. Unless you think otherwise?

Comment 16

[Monica Chiorean]

Verified issue as fixed on Win11x64 / Mac 15.5 using FF build 153.0b10.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

I have one more planned dot release in the schedule for this cycle. This seems like a reasonable fix to take in it. Go ahead with the nomination.

Comment 18

[Emma Zühlcke [:emz]]

Sure! Requested via lando.

Comment 19

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Users can't disable email tracking protection via ETP custom settings. Workaround: disable via about:config. Users who have email tracking protection disabled already that don't interact with the settings controls should not be affected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: Small changes to the ETP custom settings logic.
• String changes made/needed?: no
• Is Android affected?: no

Comment 20

[Emma Zühlcke [:emz]]

Attachment: Bug 2049331 - Disable email tracking protection from the redesigned ETP Custom UI.

The old ETP Custom UI couples the email tracking protection prefs to the
tracking protection checkbox and scope menu, since email tracking
protection is surfaced through the same Tracking Content UI on the
protections panel. The settings redesign reimplemented these controls but
never wrote the email tracking prefs, so disabling Tracking Content no
longer disabled email tracking protection in private windows, reintroducing
bug 1830054.

Make the redesigned etpCustomTrackingProtectionEnabled toggle and
etpCustomTrackingProtectionEnabledContext scope settings write the email
tracking prefs alongside the tracking protection prefs, mirroring the old
design's behavior.

The original testDisableTPCheckBoxDisablesEmailTP guard only runs against
the old design; extend the redesign's test_custom_tracking_protection_controls
to cover the email tracking prefs.

Original Revision: https://phabricator.services.mozilla.com/D308079

Comment 21

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7f6a36aa2e4e
https://hg.mozilla.org/releases/mozilla-release/rev/501242d9fde7

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.6 relnotes.

Comment 23

[Monica Chiorean]

Verified issue as fixed on Win11x64 / Mac 15.5 / Ubuntu 24.04 using FF build 152.0.6.