2049373 - [Nova] Purple flicker when opening a private window and when opening a website in a private window

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P3)

Description

[Sören Hentzschel]

STR:

1. Set browser.nova.enabled to true
2. Open a private window
3. Open a website

Actual:

After step 2 and after step 3 a purple background appears very briefly. It seems to be exactly the same background that the private window start page had before bug 2033037. And since it's purple, while the new background for the private windows' start page is deep black, it's very noticeable and distracting.

Expected:

Ideally no flicker at all, but at least it should use the same background as the private window start page.

Screencast of the issue: https://youtu.be/zlJ0sUcLzm4

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 2049373 - Fix nova PBM purple content-area backdrop flicker. r=#desktop-theme-reviewers!

The chrome-level --tabpanel-background-color stayed the legacy purple gradient with nova enabled, flashing behind the <browser> on window open, navigation, and fullscreen top-bar focus. Override it to the nova canvas for private windows.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e886f6a04ba
https://hg.mozilla.org/integration/autoland/rev/9224f0c67b3c
Fix nova PBM purple content-area backdrop flicker. r=desktop-theme-reviewers,sfoster

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9224f0c67b3c