20504 - [DOGFOOD] Printing Crashes in the nsViewManager

Status: VERIFIED FIXED

(Core :: Web Painting, defect, P3)

Description

[dcone (gone)]

Printing crashes in nsViewManager::ViewToWidget()
The aWidgetView member is null,, and KABOOM..

Comment 1

[leger]

Putting on PDT+ radar.

Comment 2

[Paul MacQuiddy]

*** Bug 20531 has been marked as a duplicate of this bug. ***

Comment 3

[Patrick C. Beard]

Here's a patch to fix this. Please review and I'll check it in.

This should fix the crash you may be seeing when printing. On the other hand, I
see another crash when printing with GFX scrollbars turned on. Evidently the
frame hierarchy isn't exactly what you're expecting it to be when GFX scrollbars
are used.

Index: mozilla/view/src/nsViewManager.cpp
===================================================================
RCS file: /cvsroot/mozilla/view/src/nsViewManager.cpp,v
retrieving revision 3.137
diff -b -r3.137 nsViewManager.cpp
2251d2250
< 	nsRect widgetRect = aRect;
2252a2252,2253
> 	if (widgetView != nsnull) {
> 		nsRect widgetRect = aRect;
2259a2261
> 		}

Comment 4

[dcone (gone)]

This fix looks good...

Comment 5

[Christine Hoffman]

Fixed per reporter. Verifying it so.