2050591 - Replace ktlint with ktfmt for android linting and autoformat mobile/android/** files

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, enhancement)

Description

[Aaditya Dhingra [:adhingra]]

To see if we want to use https://github.com/facebook/ktfmt instead of or in addition to ktlint.

Comment 1

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Setup ktfmt for android linting

Comment 2

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 2050591 - Run ktfmt on fenix

Comment 3

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 2050591 - Run ktlint after ktfmt on fenix

Comment 4

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 2050591 - Run ktfmt on focus

Comment 5

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 2050591 - Run ktlint after ktfmt on focus

Comment 6

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Add ktfmt to linters

Comment 7

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Update detekt baseline configs to fix errors after ktfmt formatting.

Comment 8

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Remove ktlint and replace with ktfmt where possible

Comment 9

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format geckoview files with ktfmt.

Comment 10

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format fenix source files with ktfmt.

Comment 11

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format fenix test files with ktfmt

Comment 12

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format fenix ui test files with ktfmt.

Comment 13

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format focus files with ktfmt.

Comment 14

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format android-components files with ktfmt.

Comment 15

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Format apilint plugin files with ktfmt.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a71fe1f0d46
https://hg.mozilla.org/integration/autoland/rev/7933bea7ced6
Setup ktfmt for android linting r=ahochheiden,sfamisa,geckoview-reviewers,android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/6619d8a7fe84
https://hg.mozilla.org/integration/autoland/rev/a73ae1352d14
Add ktfmt to linters r=ahochheiden,android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/20167d0508ce
https://hg.mozilla.org/integration/autoland/rev/a088a97a74e4
Remove ktlint and replace with ktfmt where possible r=geckoview-reviewers,android-reviewers,owlish,taskgraph-reviewers,ahal,ahochheiden,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/fafdd808a2f3
https://hg.mozilla.org/integration/autoland/rev/1c5eb1d67326
Format geckoview files with ktfmt. r=geckoview-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/d0469c5e7f19
https://hg.mozilla.org/integration/autoland/rev/d7b71e8b1ec6
Format fenix source files with ktfmt. r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/d48158104cb4
https://hg.mozilla.org/integration/autoland/rev/31ac63afe670
Format fenix test files with ktfmt r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/8e38afc76776
https://hg.mozilla.org/integration/autoland/rev/987e275f8134
Format fenix ui test files with ktfmt. r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/747bf11e140d
https://hg.mozilla.org/integration/autoland/rev/57663ff81e4a
Format focus files with ktfmt. r=android-reviewers,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/1967f78d98ef
https://hg.mozilla.org/integration/autoland/rev/c63a2448da19
Format android-components files with ktfmt. r=android-reviewers,webcompat-reviewers,twisniewski,jonalmeida
https://github.com/mozilla-firefox/firefox/commit/8825237d2598
https://hg.mozilla.org/integration/autoland/rev/8d2b55769a1e
Update detekt baseline configs to fix errors after ktfmt formatting. r=android-reviewers,gl
https://github.com/mozilla-firefox/firefox/commit/b4f712874bb3
https://hg.mozilla.org/integration/autoland/rev/1d723ff15ec0
Format apilint plugin files with ktfmt. r=geckoview-reviewers,jonalmeida

Comment 17

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 2050591 - Add ktfmt formatting commits to .hg-annotate-ignore-revs and .git-blame-ignore-revs.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d36bdead529
https://hg.mozilla.org/integration/autoland/rev/db7a532cea2e
Add ktfmt formatting commits to .hg-annotate-ignore-revs and .git-blame-ignore-revs. r=RyanVM

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7933bea7ced6
https://hg.mozilla.org/mozilla-central/rev/a73ae1352d14
https://hg.mozilla.org/mozilla-central/rev/a088a97a74e4
https://hg.mozilla.org/mozilla-central/rev/1c5eb1d67326
https://hg.mozilla.org/mozilla-central/rev/d7b71e8b1ec6
https://hg.mozilla.org/mozilla-central/rev/31ac63afe670
https://hg.mozilla.org/mozilla-central/rev/987e275f8134
https://hg.mozilla.org/mozilla-central/rev/57663ff81e4a
https://hg.mozilla.org/mozilla-central/rev/c63a2448da19
https://hg.mozilla.org/mozilla-central/rev/8d2b55769a1e
https://hg.mozilla.org/mozilla-central/rev/1d723ff15ec0

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/db7a532cea2e