2050917 - DependenciesPlugin formats build-metric durations with the default locale

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, task)

Description

[Ryan VanderMeulen [:RyanVM]]

The build-metrics BuildService in DependenciesPlugin.kt formats task and phase durations with String.format("%.3f", ...) and no explicit Locale, so the decimal separator follows the build machine's default locale (e.g. 1,234 vs 1.234) and the emitted build-metrics JSON is non-deterministic. AGP 9's lint flags this as a DefaultLocale warning. Fix by passing Locale.ROOT.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2050917 - Format build-metric durations with Locale.ROOT in DependenciesPlugin. r?#android-reviewers

String.format without an explicit Locale uses the default locale's decimal separator, which makes
the build-metrics output non-deterministic. Pass Locale.ROOT so durations always use a '.' separator.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b871b5bf4b2b
https://hg.mozilla.org/integration/autoland/rev/1ebcd11abddb
Format build-metric durations with Locale.ROOT in DependenciesPlugin. r=android-reviewers,adhingra

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1ebcd11abddb