205140 - Prefs: remove "network.http.*.timeout"

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[benc]

Darin said:
http://bugzilla.mozilla.org/show_bug.cgi?id=142326#c6
pref("network.http.connect.timeout",  30);      // in seconds
pref("network.http.request.timeout", 120);      // in seconds

LXR shows that
"network.http.connect.timeout" is not in the trunk.

"network.http.request.timeout"

is referenced in:

/netwerk/protocol/http/src/nsHttpHandler.cpp, line 986 
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 987

(I put the lxr query in the URL field for convenience).

This pref does appear in ja-JP, trunk, Phoenix and Minotaur.

Comment 1

[benc]

lxr says:

network.http.request.timeout
/l10n/langpacks/nscp/ja-JP/defaults/pref/all.js, line 431 --
pref("network.http.request.timeout", 120); // in seconds
/modules/libpref/src/init/all.js, line 555 --
pref("network.http.request.timeout", 120); // in seconds
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 986 -- if (bChangedAll ||
PL_strcmp(pref, "network.http.request.timeout") == 0)
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 987 --
prefs->GetIntPref("network.http.request.timeout", &mRequestTimeout);
/mail/app/profile/all.js, line 540 -- pref("network.http.request.timeout", 120);
// in seconds
/browser/app/profile/all.js, line 384 -- pref("network.http.request.timeout",
120); // in seconds

Comment 2

[timeless]

Attachment: ok

Comment 3

[benc]

timeless: thanks! I've got all the other pref changes in patches for bug 205077,
so I'll leave in the patch you've provided.

Comment 4

[benc]

Comment on attachment 124706 [details] [diff] [review]
ok

The all.js part is already checked in, do you need a fresh patch for
nsHttpHandler-only?

Comment 5

[timeless]

Comment on attachment 124706 [details] [diff] [review]
ok

mozilla/modules/libpref/src/init/all.js 	3.517
mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp	1.96

Comment 6

[timeless]

Attachment: remove remaining instances

Comment 7

[Darin Fisher]

Comment on attachment 171480 [details] [diff] [review]
remove remaining instances

r+sr=darin

Comment 8

[timeless]

Comment on attachment 171480 [details] [diff] [review]
remove remaining instances

mozilla/embedding/browser/photon/src/EmbedPrivate.cpp	1.27
mozilla/embedding/browser/photon/src/PtMozilla.cpp	1.48
mozilla/embedding/minimo/all.js 	1.13

Comment 9

[benc]

Timeles: fixed?

Comment 10

[benc]

V/fixed.