Prefs: remove "network.http.*.timeout"

VERIFIED FIXED

Status

()

defect
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: benc, Assigned: timeless)

Tracking

Trunk
PowerPC
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 obsolete attachments)

Reporter

Description

16 years ago
Darin said:
http://bugzilla.mozilla.org/show_bug.cgi?id=142326#c6
pref("network.http.connect.timeout",  30);      // in seconds
pref("network.http.request.timeout", 120);      // in seconds

LXR shows that
"network.http.connect.timeout" is not in the trunk.

"network.http.request.timeout"

is referenced in:

/netwerk/protocol/http/src/nsHttpHandler.cpp, line 986 
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 987

(I put the lxr query in the URL field for convenience).

This pref does appear in ja-JP, trunk, Phoenix and Minotaur.
Reporter

Comment 1

16 years ago
lxr says:

network.http.request.timeout
/l10n/langpacks/nscp/ja-JP/defaults/pref/all.js, line 431 --
pref("network.http.request.timeout", 120); // in seconds
/modules/libpref/src/init/all.js, line 555 --
pref("network.http.request.timeout", 120); // in seconds
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 986 -- if (bChangedAll ||
PL_strcmp(pref, "network.http.request.timeout") == 0)
/netwerk/protocol/http/src/nsHttpHandler.cpp, line 987 --
prefs->GetIntPref("network.http.request.timeout", &mRequestTimeout);
/mail/app/profile/all.js, line 540 -- pref("network.http.request.timeout", 120);
// in seconds
/browser/app/profile/all.js, line 384 -- pref("network.http.request.timeout",
120); // in seconds
Assignee

Comment 2

16 years ago
Posted patch ok (obsolete) — Splinter Review
Reporter

Comment 3

16 years ago
timeless: thanks! I've got all the other pref changes in patches for bug 205077,
so I'll leave in the patch you've provided.
Reporter

Comment 4

15 years ago
Comment on attachment 124706 [details] [diff] [review]
ok

The all.js part is already checked in, do you need a fresh patch for
nsHttpHandler-only?
Attachment #124706 - Flags: review?(darin)

Updated

15 years ago
Attachment #124706 - Flags: superreview+
Attachment #124706 - Flags: review?(darin)
Attachment #124706 - Flags: review+
Assignee

Updated

15 years ago
Assignee: benc → timeless
Assignee

Comment 5

15 years ago
Comment on attachment 124706 [details] [diff] [review]
ok

mozilla/modules/libpref/src/init/all.js 	3.517
mozilla/netwerk/protocol/http/src/nsHttpHandler.cpp	1.96
Attachment #124706 - Attachment is obsolete: true
Assignee

Comment 6

15 years ago
Posted patch remove remaining instances (obsolete) — Splinter Review
Attachment #171480 - Flags: superreview?(darin)
Attachment #171480 - Flags: review?(dougt)

Comment 7

15 years ago
Comment on attachment 171480 [details] [diff] [review]
remove remaining instances

r+sr=darin
Attachment #171480 - Flags: superreview?(darin)
Attachment #171480 - Flags: superreview+
Attachment #171480 - Flags: review?(dougt)
Attachment #171480 - Flags: review+
Assignee

Comment 8

15 years ago
Comment on attachment 171480 [details] [diff] [review]
remove remaining instances

mozilla/embedding/browser/photon/src/EmbedPrivate.cpp	1.27
mozilla/embedding/browser/photon/src/PtMozilla.cpp	1.48
mozilla/embedding/minimo/all.js 	1.13
Attachment #171480 - Attachment is obsolete: true
Reporter

Comment 9

15 years ago
Timeles: fixed?
Assignee

Updated

15 years ago
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Reporter

Comment 10

14 years ago
V/fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.