205077 - Prefs: Networking cleanup for trunk

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[benc]

Over the last two major version releases, we've gotten a much better foundation
for dealing w/ preferences.

Bug 158384 - generic preferences documentation
Bug 198252 - guide to networking prefs.
(http://www.mozilla.org/quality/networking/docs/netprefs.html)

I've also learned enough to use LXR, pull the tree, and write patches to change
the prefs files.

So what I want to do is the following:

1- Document all Networking releate prefs UI.
2- Document all functioning networking prefs.
3- File bugs against any discrepancies.
4- Remove any useless prefs entries from all product trees.

This will be a working meta bug, so process comments should go here, technical
items related to blocking bugs should go in the bug, please.

Comment 1

[benc]

Attachment: (trunk) patch /cvsroot/mozilla/modules/libpref/src/init/all.js

has changes for all bugs except bug 205140, which timeless is patching
separately.

Comment 2

[benc]

Attachment: ("browser") patch for /cvsroot/mozilla/browser/app/profile/all.js

removes all prefs except "network.hosts.socks" (removed already) and
"network.http.*.timeout" (removing separately)

Comment 3

[benc]

Attachment: ("mail") patch /cvsroot/mozilla/mail/app/profile/all.js

http timeout will be handled separately.

Comment 4

[pkjoshi]

Attachment: ("calendar") patch for /cvsroot/mozilla/calendar/sunbird/app/profile/all.js

removes all unwanted prefs except "network.http.*.timeout" (removing
separately)

Comment 5

[pkjoshi]

Attachment: ("l10n") patch for /cvsroot/mozilla/l10n/langpacks/nscp/ja-JP/defaults/pref/all.js

removes all unwanted prefs except "network.http.*.timeout.

Comment 6

[benc]

Attachment: trunk patch

leaves network.online, removes network.related.enabled

Comment 7

[benc]

Comment on attachment 137907 [details] [diff] [review]
trunk patch

review please! Asa says do trunk first, then think about both 1.6f and 1.4.2...

Comment 8

[Darin Fisher]

Comment on attachment 137907 [details] [diff] [review]
trunk patch

r=darin

btw, these "dead" prefs appear in other pref files scattered throughout the
tree.  i recommend searching LXR on the pref names to locate the other files.

Comment 9

[benc]

There was a pref cleanup where other products now do something like copy all.js,
rather than having their own copy in their own tree.

I'll own cleaning up the patch list and hunting down any spurious entries in the
tree.

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 137907 [details] [diff] [review]
trunk patch

a=mkaply

Comment 11

[benc]

Bryner mentioned a couple more prefs to look at in:

http://bugzilla.mozilla.org/attachment.cgi?id=59999&action=view

I'll start researching those soon.

Comment 12

[Frank Wein [:mcsmurf]]

Comment on attachment 124710 [details] [diff] [review]
(trunk) patch  /cvsroot/mozilla/modules/libpref/src/init/all.js

removing obsolete review request

Comment 13

[benc]

Comment on attachment 128773 [details] [diff] [review]
("l10n") patch for /cvsroot/mozilla/l10n/langpacks/nscp/ja-JP/defaults/pref/all.js

None of the offending entries appears in this file anymore (per lxr).

Comment 14

[Frank Wein [:mcsmurf]]

The trunk patch has just been checked in by timeless:
2004-04-07 23:43	timeless%mozdev.org 	mozilla/ embedding/ minimo/ all.js 
1.6 	0/9  	Bug 205077 Prefs: Networking cleanup for trunk
patch by [e-mail] r=darin a=mkaply
2004-04-07 23:43	timeless%mozdev.org 	mozilla/ modules/ libpref/ src/ init/
all.js 	3.515 	0/10 

please resolve as fixed or leave it if you want to include something from that
in 1.4.2 branch.

Comment 15

[benc]

Comment on attachment 124711 [details] [diff] [review]
("browser") patch for /cvsroot/mozilla/browser/app/profile/all.js

/mozilla/browser/app/profile/all.js is gone now.

Comment 16

[benc]

Comment on attachment 124714 [details] [diff] [review]
("mail") patch /cvsroot/mozilla/mail/app/profile/all.js

mozilla/mail/app/profile/all.js is gone.

Comment 17

[benc]

Comment on attachment 128764 [details] [diff] [review]
("calendar") patch for /cvsroot/mozilla/calendar/sunbird/app/profile/all.js

mozilla/calendar/sunbird/app/profile/all.js is gone now.

Comment 18

[timeless]

Comment on attachment 137907 [details] [diff] [review]
trunk patch

mozilla/modules/libpref/src/init/all.js 	3.515
mozilla/embedding/minimo/all.js 	1.6

Comment 19

[sjw]

All child tasks are done.