2051406 - Update header on Account Hub views to remove Branding Header from all views except first and finish/last

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P2)

Description

[Kevin Lamping]

For all Account Hub subviews in Email/Address Book flows, remove the Header wordmark & logo from any page that isn't the start/finish of said flow, so that it matches the design.

Functional requirements:

• Header wordmark & logo removed from all non-start/finish views
• Header text updated to match size/style in Zeplin designs across views

Outstanding questions:

• There currently is a 'showBrandingHeader' function in the account-hub-header.mjs file. There is no 'hideBrandingHeader' function. Should there be one?
• Should the branding header be visible or hidden by default?

Implementation specifics:

• Fix the styling on the header component, so that the 'hidden' attribute properly hides when set
• Add tests for the header component validating the header is properly visible/hidden, depending on attribute

References:

• https://zpl.io/ZqPMkBX (See 'behavior' note)
• Element discussion: https://matrix.to/#/!eLmsPQxHiUzeSCFVmq:mozilla.org/$B1cJxY3yyQIeaEvCYCEAl0PxIzdc7ihjWpDKlhRbSPg?via=mozilla.org&via=matrix.org&via=humanoids.be

Relevant files/functions:

• https://searchfox.org/comm-central/source/mail/components/accountcreation/content/widgets/account-hub-step.mjs#94
• https://searchfox.org/comm-central/source/mail/components/accountcreation/content/widgets/account-hub-header.mjs#291
• https://searchfox.org/comm-central/source/mail/themes/shared/mail/accountHub.css#315

Comment 1

[Martin Giger [:freaktechnik]]

Changes to the hidden attribute UA styles means we now don't show the branding header in the first email step anymore and generally only show it for steps that call showBrandingHeader.

Comment 2

[Alex Schmitz]

Attachment: Bug 2051406 - Only show branding header on the first subview of account hub. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/30a20f9f52f9
Only show branding header on the first subview of account hub. r=klamping