Closed Bug 2052048 Opened 9 days ago Closed 12 hours ago

Make the "Close as invalid" button a bit more targeted

Categories

(bugzilla.mozilla.org :: Bug Creation/Editing, task)

Production

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: xavier.lhour)

References

Details

Attachments

(1 file)

I noticed that we recently added a "Close as invalid" button (not visible to everyone but visible to users with certain privileges including myself). This button shows up between "Attach new file" and the first bug comment, and it gets in the way a little bit, which feels a bit unfortunate for something that we'll hopefully be using quite sparingly.

I'd suggest we show that button only for bugs filed by users that lack both canconfirm and editbugs flags.

Users who have canconfirm and/or editbugs privileges by-definition have some level of trust, and hopefully we can trust them not to be filing invalid bugs such that we'd need this ~one-click sledgehammer to be present on their bugs.

The targeting I'm suggesting in comment 0 is just one possible approach; maybe there's an even better approach.

My main goal here is that I don't want to see this button on bugs that I file, or that my teammates file, or that trusted community members file. I'm fine having it there (just in case) on bugs from new/infrequent bugzilla users, though.

Xavier, could you look at what this would take to implement?

Assignee: nobody → xavier.lhour
Status: NEW → ASSIGNED

The change is quick; it involves adding a rule to the template and doing the same in the API.
Just one question: should I create a specific error message in the API, or reuse an existing one (such as bug_status_unresolvable)?

Blocks: 2052993

Authored by https://github.com/Xzzz
https://github.com/mozilla-bteam/bmo/commit/220f1161cba38aceef2240b1ea1694693fae4a90
[master] Bug 2052048 - Hide "Close and move to Invalid Bugs" button for bugs reported by editbugs members

Status: ASSIGNED → RESOLVED
Closed: 12 hours ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: