2052706 - Sidebar no longer interactive with mouse cursor in fullscreen mode (F11) due to auto-hide

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Kestrel]

Attachment: Trying to interact with vertical tabs in fullscreen mode

STR:

1. Launch latest Nightly 154.0a1.
2. Enter fullscreen mode (F11).
3. Move the mouse cursor to top edge of screen so toolbar and sidebar appears.
4. Move the mouse cursor over sidebar.
5. Try to switch tabs with vertical tabs enabled.

Expected:
Sidebar remains visible while mouse cursor over it in fullscreen mode.

Actual:
Sidebar disappears after mouse cursor moves below toolbar, making it uninteractive in fullscreen mode. Impossible to switch tabs with the mouse.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=35caa667047b5a4df400247beda7b0ab2dcbc6c3&tochange=923ce0510c229edc85fa6963a138b98084c4ca61

Regressed by Bug 1927457.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2052706 - Keep sidebar interactive in F11 fullscreen autohide r?#tabbrowser-reviewers,sclements,emilio

The autohide hides the toolbox when the pointer enters FullScreen's mouse-target
rect. That rect was cached from tabpanels before the sidebar settled, so it
covered the sidebar; hovering it hid the toolbox (and the sidebar), making
vertical tabs uninteractive.

Compute the rect live in getMouseTargetRect so it follows the sidebar reveal.
Once settled, tabpanels excludes the sidebar on whichever side it sits.

Comment 2

[Sarah Clements [:sclements]]

Can you back out the original patch instead of trying to fix it in situ. There is nova foxfooding happening right now so it might become a distraction.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1927457

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d13d84f85973
https://hg.mozilla.org/integration/autoland/rev/2b60547b8393
Keep sidebar interactive in F11 fullscreen autohide r=emilio,sfoster

Comment 5

[rperta]

Backed out for causgin bc failures at browser_panelUINotifications_fullscreen.js
Backout link
Push with failures
Failure log(s)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/24af02ad6f40
https://hg.mozilla.org/integration/autoland/rev/faa328a84ba2
Keep sidebar interactive in F11 fullscreen autohide r=emilio,sfoster

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2b60547b8393
https://hg.mozilla.org/mozilla-central/rev/faa328a84ba2

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:Sylvestre, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox154 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2052706 - Keep sidebar interactive in F11 fullscreen autohide

The autohide hides the toolbox when the pointer enters FullScreen's mouse-target
rect. That rect was cached from tabpanels before the sidebar settled, so it
covered the sidebar; hovering it hid the toolbox (and the sidebar), making
vertical tabs uninteractive.

Compute the rect live in getMouseTargetRect so it follows the sidebar reveal.
Once settled, tabpanels excludes the sidebar on whichever side it sits.

Original Revision: https://phabricator.services.mozilla.com/D310514

Comment 10

[Sylvestre Ledru [:Sylvestre]]

yeah, i just did!

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8b70899aee0d
https://hg.mozilla.org/releases/mozilla-beta/rev/37a6ee5c0841