1927457 - Fullscreen mode (F11) does not hide the sidebar tools or vertical tabs on Windows and Linux

Status: REOPENED

(Firefox :: Sidebar, defect, P3)

Description

[Kestrel]

Attachment: Vertical tabs always visible in fullscreen mode

STR:

1. Start with sidebar.revamp = true or sidebar.verticalTabs = true.
2. Enter fullscreen mode (F11).

Expected:
Sidebar tools or vertical tabs are not visible in fullscreen mode unless cursor bumps screen edge.

Actual:
Sidebar tools or vertical tabs always visible.

Edge and Vivaldi do not show sidebar tools or vertical tabs in fullscreen mode. Brave shows sidebar tools in fullscreen mode by default but can be customized to only show on mouseover and tab sidebar only appears when bumping screen edge.

Comment 1

[Sarah Clements [:sclements]]

I think the visibility in full screen mode should depend on the visibility setting. Do you have it set to "Expand and collapse the sidebar" or "show and hide sidebar"?

Comment 2

[Kestrel]

It is possible to manually hide the sidebar in fullscreen mode with the "Show and hide sidebar" setting enabled but this comes at the expense of no longer being able to have a smaller collapsed sidebar. Fullscreen mode normally hides the interface automatically, this is what happens with horizontal tabs and other browsers.

Comment 3

[Ania]

Full-screen for the entire application does not usually make the same assumptions as browser elements using full-screen API do (e.g., to remove all or some UI and allow users to watch videos or play games without distractions); the former conventionally preserves users' setup.

From what I can see, neither Edge or Vivaldi alter the display of the vertical tabs in full-screen mode (I attached labeled screenshots), while Edge collapses its right-hand sidebar in the full-screen mode (which I'd argue is unexpected).

What you would like to do will be possible with the expand-on-hover functionality, but it is not an expected result of the full-screen mode behavior.

Comment 4

[Ania]

Attachment: edge-sidebar-vertical-tabs.png

Edge pre-full-screen

Comment 5

[Ania]

Attachment: edge-full-screen 1.png

Edge fullscreen

Comment 6

[Ania]

Attachment: vivaldi-vertical-tabs.png

Comment 7

[Ania]

Attachment: vivaldi-full-screen.png

Vivaldi fullscreen

Comment 8

[Sarah Clements [:sclements]]

Thanks for weighing in Ania - I'll mark this as "won't fix".

Comment 9

[Kestrel]

Those examples are all on Mac which has non-standard fullscreen behavior. Browsers on Windows and Linux treat fullscreen mode (F11) as a presentation mode which auto-hides the interface.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1925241: S3

:sclements, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Comment 12

[Milos Kaurin]

I would also like to +1 this as a bug report. I don't think vivaldi and edge should be an example of what to follow.

If I press F11, I expect the same behaviour in Firefox as with horizontal tabs - which means to hide vertical tabs.

Comment 13

[Milos Kaurin]

(In reply to Sarah Clements [:sclements] | PTO until Jan 2 from comment #1)

I think the visibility in full screen mode should depend on the visibility setting. Do you have it set to "Expand and collapse the sidebar" or "show and hide sidebar"?

Both of these options result in the same. Pressing F11 does not hide vertical tabs

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

Contrary to comment #5, Microsoft Edge on Windows hides the vertical tabs on Windows on fullscreen, as of version 132.0.2957.140 on the stable channel. (Which is already mentioned in comment #9 but just reconfirming)

Comment 15

[Mike Kaply [:mkaply]]

This also breaks kiosk mode.

Comment 16

[:Gijs (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #15)

This also breaks kiosk mode.

Can you file a separate bug for this? Kiosk mode is probably easier to address because there is no need to be able to re-show the tabs. It's not clear to me from this report what the expectation would be for F11 fullscreen which I do not regularly use; naively I guess I would expect that tabs would do the same as in horizontal mode and so there's some way to cause the sidebar + tabs to re-show, which would need more complex (and different) code than "just" hiding them outright while in kiosk mode.

Comment 17

[Mike Kaply [:mkaply]]

Done - bug 1948934

Kiosk mode just uses fullscreen though.

We don't show the toolbox in the kiosk case:

https://searchfox.org/mozilla-central/source/browser/base/content/browser-fullScreenAndPointerLock.js#857

Comment 18

[Creak]

It took me 2 mins to get this bug once I enabled this feature.

My use case is that I like to have a Twitch stream w/ the chat. So what Ido is:

1. go to a Twitch channel
2. enter studio mode (Alt+T)
3. enter app fullscreen (F11)

Actual:
If you have horizontal tabs, the tabs disappear.
If you have vertical tabs, the tabs stay.

Expected:
I'd like the tabs to be hidden no matter their layout.
In case of vertical tabs, reaching either the top or left edges with the mouse cursor should show both the top and left bars.
In case of horizontal tabs, reaching either the top edge only with the mouse cursor should show the top bars.

Comment 22

[Denys:denyshon]

[Tracking Requested - why for this release]:

Comment 23

[howiejc]

Confirmed bug still present as of 142.0.1

Comment 24

[:Gijs (he/him)]

It's not useful to keep updating version fields or commenting here. Unless the bug is marked fixed it probably isn't.