Open Bug 2052856 Opened 4 months ago Updated 3 months ago

Error in Browser Toolbox when showing DevTools highlighters (missing InspectorActor for content_script targets)

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox-esr140 unaffected, firefox-esr153 unaffected, firefox152 unaffected, firefox153 unaffected, firefox154 wontfix, firefox155 fix-optional)

Tracking Status
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox152 --- unaffected
firefox153 --- unaffected
firefox154 --- wontfix
firefox155 --- fix-optional

People

(Reporter: nchevobbe, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Steps to reproduce

  1. Make sure to have an extension with content script installed (e.g. uBlock)
  2. Open the toolbox
  3. Show a highlighter (e.g. the rulers)

The browser toolbox console has the following error: Error: Unexpected packet root, {"from":"root","error":"noSuchActor","message":"No such actor for ID: undefined"}

The error actually comes from

_getOrCreateActor (resource://devtools/server/devtools-server-connection.js#188)
getTargetScopedActor (resource://devtools/server/actors/targets/base-target-actor.js#202)
#updateHighlighters (resource://devtools/server/actors/targets/base-target-actor.js#338)
updateTargetConfiguration (resource://devtools/server/actors/targets/base-target-actor.js#250)
addOrSetSessionDataEntry (resource://devtools/server/actors/targets/session-data-processors/target-configuration.js#20)
addOrSetSessionDataEntry (resource://devtools/server/actors/targets/base-target-actor.js#87)
#addOrSetSessionDataEntry (resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs#412)
receiveMessage (resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs#323)

where in https://searchfox.org/firefox-main/rev/d154a3eb431156b2bd63d3d5f96c82655b4e782d/devtools/server/actors/targets/base-target-actor.js#196,202

getTargetScopedActor(prefix) {
...
  return this.conn._getOrCreateActor(form[prefix + "Actor"]);

prefix is inspector.

So basically, this fails because we try to retrieve the InspectorActor for a type of target (content_script) which don't have an Inspector actor

Set release status flags based on info from the regressing bug 1247553

Severity: -- → S3
Priority: -- → P3

Hi Julian, I'm the assigned REO for this week. This bug is marked as regression for 154. Could we get an assignee to investigate a fix for this cycle?

Flags: needinfo?(jdescottes)

This is a P3/S3, just logspam. Wontfix for 154, fix-optional for 155

Flags: needinfo?(jdescottes)

Set release status flags based on info from the regressing bug 1247553

You need to log in before you can comment on or make changes to this bug.