Closed Bug 2053088 Opened 4 months ago Closed 13 days ago

Establish the outer proxy connection through Happy Eyeballs

Categories

(Core :: Networking: HTTP, task, P2)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [necko-triaged])

Attachments

(2 external files)

Happy Eyeballs currently handles only direct-origin connections. Extend it to also establish the outer connection to an MASQUE or HTTPS CONNECT proxy over, so the Firefox-to-proxy hop gets dual-stack racing and can reuse the shared Happy Eyeballs code.

Gated by network.http.happy_eyeballs.proxy_enabled (default off). When enabled,
the outer Firefox<->proxy connection for HTTPS CONNECT and MASQUE proxies is
driven by HappyEyeballsConnectionAttempt instead of DnsAndConnectSocket.

Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2df6be8ce1e5 https://hg.mozilla.org/integration/autoland/rev/4493e6ddd75b Establish the outer proxy connection via Happy Eyeballs, r=mxinden https://github.com/mozilla-firefox/firefox/commit/2305fc786903 https://hg.mozilla.org/integration/autoland/rev/dd8ec84b1632 Use Happy Eyeballs for SOCKS proxies via by-name connection attempts, r=necko-reviewers,valentin,mxinden
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3b2c49086e29 https://hg.mozilla.org/integration/autoland/rev/059f2d7508ac Revert "Bug 2053088 - Use Happy Eyeballs for SOCKS proxies via by-name connection attempts, r=necko-reviewers,valentin,mxinden" for causing xpc & bc network related failures
Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b95879ca6b82 https://hg.mozilla.org/integration/autoland/rev/e6dd02765dcb Establish the outer proxy connection via Happy Eyeballs, r=mxinden https://github.com/mozilla-firefox/firefox/commit/8358ea1327a4 https://hg.mozilla.org/integration/autoland/rev/06cd3f61c5f1 Use Happy Eyeballs for SOCKS proxies via by-name connection attempts, r=necko-reviewers,valentin,mxinden
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9c74e3558383 https://hg.mozilla.org/integration/autoland/rev/f22ea4e05d43 Revert "Bug 2053088 - Use Happy Eyeballs for SOCKS proxies via by-name connection attempts, r=necko-reviewers,valentin,mxinden" for causing bc tests failures at browser/components

Backed out for causing bc tests failures, mochitests and devtools failures
Backout Link
Push with failures
backfills
backfills
backfills

Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/deb0af4d7d83 https://hg.mozilla.org/integration/autoland/rev/b54e33d5df82 Establish the outer proxy connection via Happy Eyeballs, r=mxinden https://github.com/mozilla-firefox/firefox/commit/d0a1285fcb61 https://hg.mozilla.org/integration/autoland/rev/dfbab17a5f2d Use Happy Eyeballs for SOCKS proxies via by-name connection attempts, r=necko-reviewers,valentin,mxinden
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Regressions: 2089206
Regressions: 2089933
QA Whiteboard: [qa-triage-done-c162/b161]

Perfherder has detected a talos performance change from push dfbab17a5f2d0febe3138dd08de1b0d15d7a21e6.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
4% tp5o_webext (doc) macosx1500-aarch64-shippable e10s fission stylo webrender 111.94 -> 107.34

Need Help or Information?

If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: