Closed Bug 2089933 Opened 12 days ago Closed 10 days ago

Move the hostname into the by-name target in HappyEyeballsConnectionAttempt::ProcessHappyEyeballsOutput (Coverity CID 1704736)

Categories

(Core :: Networking: HTTP, defect)

defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox160 --- unaffected
firefox161 --- wontfix
firefox162 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Regression)

Details

(Keywords: coverity, regression)

Attachments

(1 external file)

Coverity CID 1704736 (Variable copied when it could be moved).

In HappyEyeballsConnectionAttempt::ProcessHappyEyeballsOutput, the AttemptConnectionByName case builds ByNameTarget{dnsHostname}, copying dnsHostname. That string is a loop-local filled by happy_eyeballs_process_output on each iteration and is not used after the call, so it can be moved with std::move(dnsHostname), like echConfig next to it.

Introduced by bug 2053088

dnsHostname is filled by happy_eyeballs_process_output on each loop
iteration and is not used after building the ByNameTarget, so move it
instead of copying it, as is already done for echConfig.

Assignee: nobody → sledru
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 2053088

Pushed by sledru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e0a405cc205f https://hg.mozilla.org/integration/autoland/rev/25da37a6233e Move the hostname into the by-name target in HappyEyeballsConnectionAttempt::ProcessHappyEyeballsOutput (Coverity CID 1704736) r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

The patch landed in nightly and beta is affected.

:Sylvestre, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox161 to wontfix if the fix can wait for the next release.

Uplift requests can be submitted from Lando: D340269.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: