2053894 - 'Search online' checkbox in Virtual Folder properties resets to unchecked after reopening the window

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[hr]

Steps to reproduce:

I checked "online search" in the virtual folder properties, saved and closed.
Opened the virtual folder properties again.

Actual results:

The checkbox "online search" is unchecked.

Expected results:

The checkbox "online search" should have remembered the saved setting.

Comment 1

[Wayne Mery (:wsmwk)]

I can reproduce this on daily. Unclear what errors in error console. I see several over different operations.

16:50:46.916 mail.activity: onDownloadCompleted: TypeError: can't access property "activity", this._syncInfoPerFolder.get(...) is undefined autosync.sys.mjs:384:16

Error: File closed subprocess_unix.worker.js:592:19
16:58:36.723 NotFoundError: No such JSProcessActor 'BrowserToolboxDevToolsProcess'

Security Error: Content at moz-nullprincipal:{b329d59a-4431-4b06-92e7-654ade28dba1} may not load or link to resource://gre/modules/subprocess/subprocess_unix.worker.js.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2053894 - Fix 'Search online' checkbox always resetting to unchecked in Virtual Folder Properties. r=#thunderbird-reviewers

The port of bug 2008041 (d89f225042b2) incorrectly moved the
checkbox.checked = false assignment outside of the conditional in
updateOnlineSearchState(). This caused the checkbox to be unchecked
every time the dialog opens, even when online search was available.

Restore the original logic: only clear the checkbox when there are
no online servers (i.e., when it's disabled).

Add a test that verifies the checkbox state is preserved across
dialog opens when online servers are in the search folders.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b7bbfb694d4
Fix 'Search online' checkbox always resetting to unchecked in Virtual Folder Properties. r=mkmelin

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9606554 [details]
Bug 2053894 - Fix 'Search online' checkbox always resetting to unchecked in Virtual Folder Properties. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression compared to ESR 140.
• User impact if declined: 'Search online' checkbox always unchecked regardless of the actual setting.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined change, covered by tests.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None.

Comment 5

[Corey Bryant]

Comment on attachment 9606554 [details]
Bug 2053894 - Fix 'Search online' checkbox always resetting to unchecked in Virtual Folder Properties. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Francesco (no longer active, use PM for contact)]

Thunderbird 153.0b9
https://hg.mozilla.org/releases/comm-beta/rev/fb1f8b9a96b0a11c01be26a3805fe5ac6377d97a