2054108 - Implement nsCMSMessage::GetEncryptionCert to show the encryption certificate to which an S/MIME message was encrypted

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, enhancement)

Description

[Kai Engert [:KaiE:]]

I notice that the suggested code in bug 229724 provides helper code that we could reuse for finding the recipient encryption certificate of an S/MIME message, to implement nsCMSMessage::GetEncryptionCert().

That would allow the message security info to show it. That's already hooked up with strings prepared, but is not yet implemented.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 2054108 - Implement nsCMSMessage::GetEncryptionCert. r=edicharry

Comment 2

[Eleanor Dicharry]

I didn't land this because when I was trying to land it, I got compile errors on my (MacOS) build, even following a clobber:

E ld64.lld: error: undefined symbol: CERT_FindCertBySubjectKeyID
 9:42.05 E >>> referenced by nsCMS.cpp:161 (./../../../../../comm/mailnews/extensions/smime/nsCMS.cpp:161)
 9:42.05 E >>>               ../../../comm/mailnews/extensions/smime/Unified_cpp_extensions_smime0.o:(symbol nsCMSMessage::GetEncryptionCert(nsIX509Cert**)+0x170)
 9:42.05 E >>> referenced by nsCMS.cpp:161 (./../../../../../comm/mailnews/extensions/smime/nsCMS.cpp:161)
 9:42.05 E >>>               ../../../comm/mailnews/extensions/smime/Unified_cpp_extensions_smime0.o:(symbol nsCMSMessage::GetEncryptionCert(nsIX509Cert**)+0x124)
 9:42.08 E clang++: error: linker command failed with exit code 1 (use -v to see invocation)
 9:42.08 E make[4]: *** [../../../dist/bin/XUL] Error 1
 9:42.08 E make[3]: *** [toolkit/library/build/target] Error 2
 9:42.08 E make[3]: *** Waiting for unfinished jobs....

Comment 3

[Dana Keeler (she/her) [:keeler]]

You'll probably need to add that symbol to https://searchfox.org/comm-central/source/mailnews/nss-extra.symbols

Comment 4

[Kai Engert [:KaiE:]]

Thanks for catching the build error before landing. I had been too optimistic and had limited earlier try builds to linux.

New macos try build that adds to nss-extra.symbols as suggested:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=bdb4304358f0a446ca1d2ffcb63bc599c2555895

Comment 5

[Kai Engert [:KaiE:]]

try build works, thanks!

Comment 6

[Eleanor Dicharry]

This failed to apply during landing.

Comment 7

[Kai Engert [:KaiE:]]

rebased and merged

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f13c32509770
Implement nsCMSMessage::GetEncryptionCert. r=edicharry