229724 - Message Security dialog should show cipher and strength for encrypted messages, received or sent

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, enhancement)

Description

[Ralf Hauser]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031129
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031129

there are still quite some export-versions for example of Outlook around. When
receiving such messages with Thunderbird, it should be visible whether the
payload was only with 40 bit key strength encrypted and what algorithm was used.
Same for outgoing mail from Thunderbird.
This could be added to the dialog as per the attachment to Bug 188320

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

This feature has been requested MANY times over many years.  It appears 
that all the bugs/RFEs for it have been resolved "expired", but the desire
for this feature is not diminished any.  So, I'm putting this back on the 
radar.

Comment 4

[Taavi]

Attachment: Bug 229724 - Display cryptographic algorithm details in S/MIME security info panel. r=edicharry,tobyp

Show signature algorithm (RSASSA-PSS, RSA, ECDSA, etc.), digest algorithm,
content encryption cipher with key size, and key encryption algorithm in
the S/MIME message security popup panel.

New nsICMSMessage attributes: signatureAlgorithmName, digestAlgorithmName,
contentEncAlgorithmName, contentEncKeySize, keyEncAlgorithmName.

Extended nsIMsgSMIMESink::signedStatus() and encryptionStatus() to pass
algorithm details from the MIME processing layer to the UI. Algorithm
information is only extracted and displayed for successfully verified
signatures and successfully decrypted messages.

Comment 5

[Phabricator Automation]

Comment on attachment 9600005 [details]
Bug 229724 - Display cryptographic algorithm details in S/MIME security info panel. r=edicharry,tobyp

Revision D288879 was moved to bug 222179. Setting attachment 9600005 [details] to obsolete.

Comment 6

[Kai Engert [:KaiE:]]

Attachment: Bug 229724 - Use a single algorithm information section, use <details>. r=edicharry

Comment 7

[Kai Engert [:KaiE:]]

When landing it's important to land both patches at the same time, because patch 1 (from Taavi) creates strings that we are amending in patch (mine).

Comment 8

[Kai Engert [:KaiE:]]

Now that all pieces are agreed on and reviewed, we're almost ready to land.

I've submitted a final try build:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=a04724ed0b5285d47bd45d188cf13049c649a9b5

Comment 9

[Kai Engert [:KaiE:]]

I've filed another follow-up patch to ensure stale information isn't visible when switching to another message.

Comment 10

[Kai Engert [:KaiE:]]

phab and bz are really slow today.
The additional patch is here:
https://phabricator.services.mozilla.com/D312988

Comment 11

[Kai Engert [:KaiE:]]

Attachment: Bug 229724 - Always clear algorithm security info when switching between messages. r=edicharry

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45d8968dd852
Display cryptographic algorithm details in S/MIME security info panel. r=edicharry,tobyp
https://hg.mozilla.org/comm-central/rev/b339dbbf06bd
Use a single algorithm information section, use

. r=edicharry
https://hg.mozilla.org/comm-central/rev/6661c3ecd1c8
Always clear algorithm security info when switching between messages. r=edicharry