Closed
Bug 2054505
Opened 1 month ago
Closed 1 month ago
Add quality filters and a clustering timeout to Auto Tab Grouping
Categories
(Core :: Machine Learning: Frontend, enhancement, P1)
Core
Machine Learning: Frontend
Tracking
()
RESOLVED
FIXED
155 Branch
People
(Reporter: jlewis, Assigned: jlewis)
References
Details
(Whiteboard: [aiaug])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
- Toolbar suggestion-count badge on
smartwindow-group-tabs-button, driven by the remaining suggestion count. - Background precompute of suggestions when the button becomes visible so the badge can appear at rest, with the model warm-up decision documented.
- "Finding groups..." loading state and a timeout on the clustering/labeling calls.
- Wait for resolved tab titles before clustering (avoid clustering on
about:blankor still-loading titles). - Harden against session restore, concurrent Smart Windows, and the window closing mid-run.
Tests: browser-chrome for badge count and the loading/timeout paths.
Flags: behind-pref+
Updated•1 month ago
|
Updated•1 month ago
|
Attachment #9609235 -
Attachment description: WIP: Bug 2054505 - Precompute Auto Tab Grouping suggestions on Smart Window init and badge the button → Bug 2054505 - Precompute Auto Tab Grouping suggestions on Smart Window init and badge the button
Updated•1 month ago
|
Attachment #9609235 -
Attachment description: Bug 2054505 - Precompute Auto Tab Grouping suggestions on Smart Window init and badge the button → Bug 2054505 - Add quality filters and a clustering timeout to Auto Tab Grouping
Pushed by jlewis@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/44217d517880
https://hg.mozilla.org/integration/autoland/rev/6f49bc5e66af
Add quality filters and a clustering timeout to Auto Tab Grouping r=desktop-theme-reviewers,fluent-reviewers,mlucks,bolsson,dao,sthompson
Comment 3•1 month ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Summary: Add the suggestion badge, background precompute, and loading/latency handling to Auto Tab Grouping → Add quality filters and a clustering timeout to Auto Tab Grouping
Building Auto Tab Grouping 'v0' - largely exploratory and gated behind a pref
No finalized designs yet, but there is a demo: https://auto-tab-grouping.netlify.app sw0626
browser.smartwindow.autoTabGrouping.enabled
SmartTabGroupingManager.isEnabled
Original Revision: https://phabricator.services.mozilla.com/D312313
Updated•1 month ago
|
Attachment #9618667 -
Flags: approval-mozilla-beta?
Updated•1 month ago
|
Attachment #9618667 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•1 month ago
|
status-firefox154:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•