2054506 - Recent groups, undo, and telemetry for Auto Tab Grouping

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, enhancement, P1)

Description

[:jlewis]

• "Recent groups" list with per-group Undo and an "Undo last group(s)" action that reverses the last creation batch (a single group or a whole "create all"). Undo uses group.ungroupTabs() so tabs stay open; consumed suggestions never resurface.
• Fix the create/undo telemetry plumbing that is currently dead in-tree: pass isUserTriggered: true (so TabGroupCreateByUser fires and telemetryUserCreateSource is honored) and supply a metricsContext on ungroup so Glean.tabgroup.ungroup records.
• New events/counts: offered, created (individual vs. all), undone (individual vs. last). No URLs or titles in any payload.

Tests: browser-chrome for undo semantics and telemetry recording.

Comment 2

[:jlewis]

Attachment: Bug 2054506 - Add a recent-groups list with ungroup and telemetry to Auto Tab Grouping

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/509835a8299d
https://hg.mozilla.org/integration/autoland/rev/9c7f6e806795
Add a recent-groups list with ungroup and telemetry to Auto Tab Grouping r=desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,omarg,bolsson,sthompson,dao,rrando

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9c7f6e806795

Comment 5

[:jlewis]

Attachment: Bug 2054506 - Add a recent-groups list with ungroup and telemetry to Auto Tab Grouping

Building Auto Tab Grouping 'v0' - largely exploratory and gated behind a pref
No finalized designs yet, but there is a demo: https://auto-tab-grouping.netlify.app sw0626

browser.smartwindow.autoTabGrouping.enabled
SmartTabGroupingManager.isEnabled

Original Revision: https://phabricator.services.mozilla.com/D312523

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Part of core functionality for Smart Window's new Auto Tab Grouping (or 'Organize Tabs') feature. Required for it to be feature-complete, and is gated behind an additional pref in Smart Window.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Set prefs to true:

browser.smartwindow.autoTabGrouping.enabled
SmartTabGroupingManager.isEnabled

Open Smart Window > open new Auto Tab Grouping button > verify menu opens and works as expected. Ensure that 'Ungroup' button in menu exists and works as expected.

• Risk associated with taking this patch: medium
• Explanation of risk level: This is code added to a feature specific to Smart Window, and has an additional gate - as it stands, it will have quite a small user base if any. Code is backed by automated testing as well, but still worth noting as 'medium' as it is a feature that will appear in the browser chrome.
• String changes made/needed?: All string changes associated with Auto Tab Grouping are in locales-preview
• Is Android affected?: no

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5a6c0b9b6b91
https://hg.mozilla.org/releases/mozilla-beta/rev/af690a607212

Comment 8

[Rares Doghi, Desktop QA]

Attachment: Autotabgroups.mp4

Hi, I'm trying to verify this fix but the Auto tab groups panel will not suggest any Tab groups in Beta 154.0b5, I have multiple tabs opened from the same domain but it seems that no Tab groups are available, Please take a look, also can you share the document with the Telemetry events ?

Comment 9

[:jlewis]

Hey Rares, there are a few factors here. First is prefs which you likely have configured properly already:

All must be true:
browser.smartwindow.enabled
browser.smartwindow.firstrun.hasCompleted
browser.smartwindow.autoTabGrouping.enabled
browser.ml.enable

Additionally, did you run 'Undo' at any point? It doesn't re-render groups if undo has already been called - though that issue has already been addressed in a follow-up. It could also be due to the models not having downloaded yet, which is also fixed here - if you close the menu, give it a minute or two, and re-open, does it now appear?

Finally, it could be related to cohesion and how the model detects grouping quality. You may want to try a variety of different domains too.

A lot of moving parts here, apologies :)

Comment 10

[:jlewis]

https://docs.google.com/spreadsheets/d/1eEDfKdPECzFYQm5_gkIz8lG_t32VPrCQwO-ZMvJpUpM/edit?gid=0#gid=0 (not implemented yet)

Comment 11

[Ed Lee :Mardak]

rares was asking about the telemetry to verify that landed as part of this bug. the doc from comment 10 is for bug 2058218

there were 3 that landed / uplifted, so do those want to be verified as they'll be reused for the followup telemetry bug or will they not be relevant?

https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/smart_window_auto_tab_group_created
https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/smart_window_auto_tab_group_offered
https://dictionary.telemetry.mozilla.org/apps/firefox_desktop/metrics/smart_window_auto_tab_group_undone

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly and our latest Beta 154.0b6, I was also able to test the 3 Telemetry events mentioned in Comment 11, However I did come across an issue where It would only show 2 Tab groups and in them completely unrelated Tab grouped together, is that ok ? Also after I created one of the groups and reopened the Organize tabs panel, It would show more tab groups with more related tabs and after undoing the previously created tab group it would show again 2 Tab groups with all tabs completely unrelated grouped together. Should I log issues for these ? or this is just the 1st stage of Auto Tab groups ?

Comment 13

[:jlewis]

The landed telemetry will be replaced and hopefully uplifted in the upcoming week, though it is good to have the stopgap verified even if it's a bit annoying to do that, so thank you for understanding!

Work is currently being done on the models side to better grouping suggestions and cohesion; I wouldn't file anything new quite yet, and instead would look at the ML patches being landed as part of this project. Thanks!