2054545 - Do not allow landing patches where the author is Hackbot

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P2)

Description

[Suhaib Mujahid [:suhaib]]

Hackbot can now submit patches to Phabricator, with Hackbot ([e-mail]) listed as the author. However, we don't want to land patches that aren't owned by a developer who understands the change, takes ownership of it, and makes any necessary modifications, ideally even before requesting code review.

The current flow is to use Phabricator's "Commandeer" feature to take over the revision, which changes the author to the person who commandeered it.

Given this, we need to:

• Prevent landing any patch where Hackbot is still listed as the author (i.e., the revision has not been commandeered).
• Attribute correctly on landing: the patch author should be the person who commandeered the revision, even if Phabricator's commit metadata still shows Hackbot as the author.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] revisions: block hackbot commits (bug 2054545) (#1337)

Comment 2

[BMO Github Automation]

Authored by https://github.com/zzzeid
https://github.com/mozilla-conduit/lando/commit/1937731a1775f633976af4482c21ea107eae7646
[main] revisions: block hackbot commits (bug 2054545) r=suhaibmujahid,Magnolia-Liu