Hackbot revision patch author should be the person who commandeered the revision
Categories
(Conduit :: Lando, enhancement)
Tracking
(Not tracked)
People
(Reporter: suhaib, Unassigned)
References
Details
The patch for bug 2054545 take care of prevent landing any patch where Hackbot is still listed as the author (i.e., the revision has not been commandeered). However, we still need to attribute correctly on landing when the patch is commandeered. Thus, the patch author should be the person who commandeered the revision, even if Phabricator's commit metadata still shows Hackbot as the author.
|
||
Comment 1•7 days ago
|
||
The patch author in Lando is determined by the diffs in the patch, not the revision (i.e., the "push" via moz-phab). Lando does not look at the revision to determine authorship. I think if we're compelling users to amend and push their own commits, nothing needs to be done here to ensure the landing is attributed to the correct author.
Commandeering would be needed to ensure that the workflow on Phabricator is as expected (i.e., a reviewer is requesting changes from an author and not from Hackbot).
This may be a WONTFIX, if I understand the request correctly.
|
Reporter | |
Comment 2•7 days ago
|
||
The patch author in Lando is determined by the diffs in the patch, not the revision
This is clear from the docs, and this is whey I filed this bug.
I think if we're compelling users to amend and push their own commits, nothing needs to be done here to ensure the landing is attributed to the correct author.
By default, amending a commit doesn’t change the author. Furthermore, if there are no changes to make, amending the commit is unnecessary. Picking up the commander as the author when landing will significantly improve the user experience.
Commandeering would be needed to ensure that the workflow on Phabricator is as expected (i.e., a reviewer is requesting changes from an author and not from Hackbot).
Actually, I'm working on support for asking for changes from the Hackbot. Though, the commandeering goal in the Hackbot workflow is to identify who takes the ownership of the patch. That person will do the author role when something is required, like landing the patch, responding to reviews, following up on regressions, etc...
Description
•