2055406 - .icon-button places icon on the wrong position on RTL

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Attachment: image.png

When using a RTL language the icon on the New Message or New Event buttons isn't placed at the correct position.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 2055406 - On RTL fix the icon position of the .icon-button. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0f40c9aa27c3
On RTL fix the icon position of the .icon-button. r=arschmitz

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9609425 [details]
Bug 2055406 - On RTL fix the icon position of the .icon-button. r=#thunderbird-front-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Buttons like "New Message" or "New Event" on RTL locales could be unreadable because of the misposition of the icon.
• User impact if declined:
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS change
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: no

Comment 4

[Corey Bryant]

Comment on attachment 9609425 [details]
Bug 2055406 - On RTL fix the icon position of the .icon-button. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta
Approved for release
Approved for esr153

Comment 5

[Stephen King (:sking)]

Thunderbird 154.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bb12a19d965a

Comment 6

[Corey Bryant]

Thunderbird 153.0.1:
https://github.com/thunderbird/thunderbird-desktop/commit/cfc0e589e58f2df7958552ee68f3807a663d49cb

Comment 7

[Stephen King (:sking)]

Thunderbird 153.0.2esr:
https://hg.mozilla.org/releases/comm-esr153/rev/a23ecd9dfd93