2056384 - Create Custom Messaging Surface inside Sidebar Chatbot for SW promo

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task, P1)

Description

[mlucks]

Scope of this ticket is to create a custom messaging surface inside CW sidebar chat bot UI as per figma here

Surface should be integrated with messaging system ASRouter for its trigger, frequency, targeting, telemetry and experiment needs

Acceptance Criteria

Current trigger requirement - User clicks in sidebar chatbot icon and open chatbot. We can use sidebarToolOpened existing trigger documented here

Targeting - Opted in and not opted in users in Classic Window

Frequency - max 3 times with gap of 7 days between unless user clicks primary CTA ( please note Don’t Show Again submenu button is not available with reusuable component moz-promo however supports Learn More link)

Click of Primary CTA a) takes user to Smart Window respective flow for opt-in or not opted-in users b) blocks message and doesn’t show it again

Prototype Patch implementing custom messaging surface using moz-promo reusable component. This is Option A currently discussed for callout 5 and 6. There is Option B using messaging system callout which can be done out of box. Please check with product @Bryan Mao with option chosen before starting work on this ticket

See slack thread for demo video

Comment 1

[mlucks]

UI has changed, link to updated: https://www.figma.com/design/75Z1LtkCEUJWCxoY2KyNHv/Smart-Window-Q2?node-id=6199-20246&t=HITF4IP6htpfwQbq-4

Comment 2

[mlucks]

Attachment: Bug 2056384 - Chatbot SW Promo - r?pdahiya

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/75aa172bea03
https://hg.mozilla.org/integration/autoland/rev/3daf78ed4f2f
Chatbot SW Promo - r=pdahiya,fluent-reviewers,omc-reviewers,bolsson,aminomancer

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/3daf78ed4f2f

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Needed to drive conversion to Smart Window.

This is dependent upon/should also uplift with D316953

• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Open the sidebar, open the chatbot menu, select a chatbot and the promo should be there on the bottom. You could also run the test included on the patch.
• Risk associated with taking this patch: low
• Explanation of risk level: This is a standalone promo and should only affect the UI
• String changes made/needed?: no
• Is Android affected?: no

Comment 6

[mlucks]

Attachment: Bug 2056384 - Chatbot SW Promo -

Original Revision: https://phabricator.services.mozilla.com/D313128

Comment 7

[mlucks]

Cleaned up the dependency, disregard the patch D316953 referenced in the uplift form

Comment 8

[mlucks]

More precise steps for QE testing:

Test with PanelTestProvider message

1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Set browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing to {"id":"panel_local_testing","type":"local","localProvider":"PanelTestProvider","enabled":true,"cohort":"SHOW_TEST"}
3. Restart Firefox
4. Open about:asrouter, find (or edit) a sidebar_chatbot_promo message, and click Show.

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9706ef0d095d
https://hg.mozilla.org/releases/mozilla-beta/rev/9c0c0e739a11

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Product does not want to wait for 154
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is a UI component and not affecting anything internally
• String changes made/needed?: no
• Is Android affected?: no

Comment 11

[mlucks]

Attachment: Bug 2056384 - Chatbot SW Promo - a=diannaS

Original Revision: https://phabricator.services.mozilla.com/D313128

Comment 12

[Dianna Smith [:diannaS]]

this is a pretty large patch for a dot release and it wont be in beta until monday which wont give enough to verify before the dot release.
Also it fails linting https://treeherder.mozilla.org/jobs?repo=try&revision=aa65be228440b26b33d776d7b776c445fd151c37&selectedTaskRun=EJ8T4Wi9SY2bDaK78Bq_Nw.0.

btw is there a dependency here on bug 2047653 (because that is only in Fx154)? It looks like a file added there is referenced in the patch.
Please advise.

Comment 13

[Ciprian Georgiu, Desktop QA]

Verified this issue as fixed on latest Beta 154.0b9 and Nightly 155.0a1 under Win 11 and macOS 26 arm with steps from comment 8.

Comment 14

[mlucks]

We have decided to let it ride for 154 instead, will close out the dot release branch