2056931 - Synchronize browser.shell.customIcon.id between selectable profiles

Status: RESOLVED FIXED

(Firefox :: Shell Integration, task)

Description

[Mike Conley (:mconley) (:⚙️)]

This preference is what's used to select the icon on startup of a new profile, and is how we show the selected icon in about:settings. Since all selectable profiles will be sharing the same custom icon, we should synchronize this pref.

Syncing this might also fix bug 2056386, since the pref is being used at startup to choose which icon to use - we should check that once this one is fixed.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2056931 - Synchronize custom icons between selectable profiles. r?yazan

Comment 2

[Ugi]

Hey, I know this is patch to make e.g. 2057059 less buggy until each profile can have its own AUMID. But I think it may be a regression. I find it less stressful to identify different profiles with distinctive whole icons (retro, pixelated, Momo) than with the tiny top-right inharmonious icons (a leaf, a soccer ball) introduced with the new profile system. Even if they don't combine like I reported on 2057059.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8eaee5b05609
https://hg.mozilla.org/integration/autoland/rev/fdd14aef1e89
Synchronize custom icons between selectable profiles. r=yazan,mossop

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8800d0f76ee2
https://hg.mozilla.org/integration/autoland/rev/75950fad3e76
Revert "Bug 2056931 - Synchronize custom icons between selectable profiles. r=yazan,mossop" for causing xpcshells faiulres at customIconManager.js

Comment 5

[Silaghi Andreea]

Backed out for causing TV and xpcshells failures at customIconManager.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-CRASH | browser/components/shell/test/unit/test_customIconManager.js | Test crashed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/831a9f2691ad
https://hg.mozilla.org/integration/autoland/rev/fa0f2b68ca14
Synchronize custom icons between selectable profiles. r=yazan,mossop

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fa0f2b68ca14

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Clients that use the new browser icon customization mechanism will find that their selectable profiles "go out of sync" about which icon to show, which is confusing.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This change is restricted entirely within the custom icon mechanism, which is inert unless the user actually chooses to customize / change their browser icon.
• String changes made/needed?: None.
• Is Android affected?: no

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2056931 - Synchronize custom icons between selectable profiles.

Original Revision: https://phabricator.services.mozilla.com/D313752

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/94b2b2df775c
https://hg.mozilla.org/releases/mozilla-beta/rev/2d9592a4bd4f