2058273 - Adding new prefs to permanentSharedPrefs doesn't automatically start storing them into the database

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

We only flush all prefs from permanentSharedPrefs to the database when first creating the datastore the first time a new profile is created. Any new prefs added to the list later don't appear to be stored into the database.

loadSharedPrefsFromDatabase should check if any of the prefs listed in permanentSharedPrefs weren't present in the database and if so call flushSharedPrefToDatabase on it.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 2058273 - Make sure newly added shared prefs are added to the shared database. r=#profiles-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a502487ad3c4
https://hg.mozilla.org/integration/autoland/rev/9717b5387972
Make sure newly added shared prefs are added to the shared database. r=mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5855f2824323
https://hg.mozilla.org/integration/autoland/rev/954217fe8270
Revert "Bug 2058273 - Make sure newly added shared prefs are added to the shared database. r=mossop" for causing bc failures on browser_preferences.js.

Comment 4

[Iulian Moraru]

Revert for causing bc failures on browser_preferences.js.

• Push with failures

• Failure log

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/630ac8bda815
https://hg.mozilla.org/integration/autoland/rev/5c9fd411a33e
Make sure newly added shared prefs are added to the shared database. r=mossop

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/def262bd5d4d
https://hg.mozilla.org/integration/autoland/rev/1209764b2b80
Revert "Bug 2058273 - Make sure newly added shared prefs are added to the shared database. r=mossop" for causing mochitests failures in browser_preferences.js.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_preferences.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/profiles/tests/browser/browser_preferences.js | uncaught rejection: Connection is not open.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec91c79685a9
https://hg.mozilla.org/integration/autoland/rev/cc5c8c4533f2
Make sure newly added shared prefs are added to the shared database. r=mossop

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5bd2ff7f5f89
https://hg.mozilla.org/integration/autoland/rev/2d401d7570e3
Revert "Bug 2058273 - Make sure newly added shared prefs are added to the shared database. r=mossop" for causing bc failures at browser/browser_test_current_theme_from_amo.js

Comment 10

[rperta]

Backed out for causing bc failures at browser/browser_test_current_theme_from_amo.js
Backout link
Push with failures
Failure log(s)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e321328b3d8d
https://hg.mozilla.org/integration/autoland/rev/1b392e30dc51
Make sure newly added shared prefs are added to the shared database. r=mossop

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b392e30dc51

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2058273 - Make sure newly added shared prefs are added to the shared database.

Original Revision: https://phabricator.services.mozilla.com/D314497

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6e1741bba572
https://hg.mozilla.org/releases/mozilla-beta/rev/625983383569