2057040 - custom OAuth2 cannot be disabled

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect)

Description

[Justin Tracey [:jtracey]]

Once the advanced setting for overriding the exchange OAuth fields is turned on, it never actually turns off again. This happens because SetExchangeOverrideOAuthDetails takes a bool value arg, but is checking it like a pointer.

Comment 1

[Justin Tracey [:jtracey]]

Attachment: Bug 2057040 - Let SetExchangeOverrideOAuthDetails set false. r=#thunderbird-reviewers

Comment 2

[Wayne Mery (:wsmwk)]

Please also set bugzilla version to oldest number known (or reasonable guess) to reproduce.

Comment 3

[Wayne Mery (:wsmwk)]

Please also set bugzilla version to oldest number known (or reasonable guess) to reproduce.

Comment 4

[Justin Tracey [:jtracey]]

It looks like this has been a bug since the initial implementation, which was in 145 via bug 1987797, but enabled by default in 151 via bug 1995859.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad3be0d5144b
Let SetExchangeOverrideOAuthDetails set false. r=thunderbird-reviewers,babolivier