Status

()

Core
XPCOM
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: blizzard, Assigned: blizzard)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
It would be nice if the GRE code would look in a directory for config files so
you can have more than one copy of the GRE installed on the same system with one
file for each version.  Easier than merging a single conf file, especially for rpms.
(Assignee)

Comment 1

15 years ago
Created attachment 123363 [details] [diff] [review]
patch

This scans a dir called /etc/gre.d for files that end in .conf.
(Assignee)

Updated

15 years ago
Attachment #123363 - Flags: review?(dougt)

Comment 2

15 years ago
Comment on attachment 123363 [details] [diff] [review]
patch

should we just ditch the /etc/gre.conf file?

nit: runon:
+  // Open the directory provided and try to read any files in that
+  // directory that end with .conf, looking for an entry that might
+  // point to the GRE that we're interested in.

Do you want to instead of the final names in the config directory have version
information express in the file name?  That way you don't have to read all
files in that directory when looking for a particular version.
(Assignee)

Comment 3

15 years ago
You can still have more than one version in the same file, I still wanted to
support that.  I don't mind still supporting /etc/gre.conf.   Doesn't hurt anything.
(Assignee)

Comment 4

15 years ago
Created attachment 123702 [details] [diff] [review]
patch #2

Patch that fixes doug's nit.
Attachment #123363 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #123363 - Flags: review?(dougt)
(Assignee)

Updated

15 years ago
Attachment #123702 - Flags: review?(dougt)

Comment 5

15 years ago
Comment on attachment 123702 [details] [diff] [review]
patch #2

looks good.
Attachment #123702 - Flags: review?(dougt) → review+
(Assignee)

Comment 6

15 years ago
Comment on attachment 123702 [details] [diff] [review]
patch #2

Looking for 1.4 approval.  I'd like to have this in before 1.4 so that we can
start having multiple versions on unix, if required.
Attachment #123702 - Flags: approval1.4?

Comment 7

15 years ago
Comment on attachment 123702 [details] [diff] [review]
patch #2

a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123702 - Flags: approval1.4? → approval1.4+
(Assignee)

Comment 8

15 years ago
Checked in.  Thanks!
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.