205752 - support for /etc/gre.d/

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Christopher Blizzard (:blizzard)]

It would be nice if the GRE code would look in a directory for config files so
you can have more than one copy of the GRE installed on the same system with one
file for each version.  Easier than merging a single conf file, especially for rpms.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: patch

This scans a dir called /etc/gre.d for files that end in .conf.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 123363 [details] [diff] [review]
patch

should we just ditch the /etc/gre.conf file?

nit: runon:
+  // Open the directory provided and try to read any files in that
+  // directory that end with .conf, looking for an entry that might
+  // point to the GRE that we're interested in.

Do you want to instead of the final names in the config directory have version
information express in the file name?  That way you don't have to read all
files in that directory when looking for a particular version.

Comment 3

[Christopher Blizzard (:blizzard)]

You can still have more than one version in the same file, I still wanted to
support that.  I don't mind still supporting /etc/gre.conf.   Doesn't hurt anything.

Comment 4

[Christopher Blizzard (:blizzard)]

Attachment: patch #2

Patch that fixes doug's nit.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 123702 [details] [diff] [review]
patch #2

looks good.

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 123702 [details] [diff] [review]
patch #2

Looking for 1.4 approval.  I'd like to have this in before 1.4 so that we can
start having multiple versions on unix, if required.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 123702 [details] [diff] [review]
patch #2

a=asa (on behalf of drivers) for checkin to 1.4

Comment 8

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!