2057968 - 154.0b2 Vertical tabs sidebar only showing in one window

Status: NEW

(Firefox :: Sidebar, defect, P3)

Description

[fugswa]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:154.0) Gecko/20100101 Firefox/154.0

Steps to reproduce:

I habe vertical tabs enabled.

1. I clicked on the “Show sidebar” button in the upper left corner to show the sidebar

2. I clicked on the “Sidebar settings” button in the bottom left corner

3. I disabled the “Hide tabs and sidebar” setting

4. I enabled the “Hide tabs and sidebar” setting

5. I closed the sidebar settings

6. I opened a new Firefox window

Actual results:

The sidebar is showing in the window where I did steps 1–5 (good).
The sidebar is not showing in the other window (bad).

Expected results:

The sidebar should be showing in both windows, as it did in the Firefox versions before.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[L4Vo5]

Hello. I'm getting this too.
I can't reproduce it in a new profile.

And maybe these strange details can help:
When sidebar.revamp is false, the sidebar button on the top left reads "Show sidebars" (and only works in one window). Clicking the ones that don't work makes this error in the browser console:

CustomizableUI.sys.mjs:2829
CustomizableUI: TypeError: can't access property "hidden", cpmMenuItem is null
    toggle chrome://browser/content/sidebar/browser-sidebar.js:1171
    onCommand moz-src:///browser/components/customizableui/CustomizableWidgets.sys.mjs:301
    doWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2827
    handleWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2908

When sidebar.revamp true, and ONLY in the window that works, it instead reads "Show sidebar (Alt+Ctrl+Z)". The non-working ones still say "Show sidebars". Clicking them makes these errors :

browser-sidebar.js:1179:7
Uncaught (in promise) TypeError: can't access property "hidden", e is null
    _getRects chrome://browser/content/sidebar/browser-sidebar.js:1179
    _getRects chrome://browser/content/sidebar/browser-sidebar.js:1178
    _animateSidebarContainer chrome://browser/content/sidebar/browser-sidebar.js:1244
    handleToolbarButtonClick chrome://browser/content/sidebar/browser-sidebar.js:1443
    onCommand moz-src:///browser/components/customizableui/CustomizableWidgets.sys.mjs:299
    doWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2827
    handleWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2908

SidebarState.sys.mjs:506:40
Uncaught (in promise) TypeError: can't access property "hidden", this[#launcherContainerEl] is null
    set launcherVisible moz-src:///browser/components/sidebar/SidebarState.sys.mjs:506
    updateVisibility moz-src:///browser/components/sidebar/SidebarState.sys.mjs:483
    handleToolbarButtonClick chrome://browser/content/sidebar/browser-sidebar.js:1455
    onCommand moz-src:///browser/components/customizableui/CustomizableWidgets.sys.mjs:299
    doWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2827
    handleWidgetCommand moz-src:///browser/components/customizableui/CustomizableUI.sys.mjs:2908

Comment 3

[Dianna Smith [:diannaS]]

:kcochrane sounds alot like the regressions of bug 2047653 in 154?

Comment 4

[Kelly Cochrane [:kcochrane]]

Sounds more like bug 2056857 to me

Comment 5

[fugswa]

I made a short video to show the problem: https://www.youtube.com/watch?v=T1Lzhz5qzq0

It’s no longer possible for me to have the small vertical tab bar showing in all Firefox windows. It’s showing only in one.

Comment 6

[Dianna Smith [:diannaS]]

comment 2 def sounds like bug 2056857 but i think the initial report is different. I ran mozregression got this pushlog
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8b55e7f08435787525631dbcae3129f1946187b&tochange=6d9c8c01dcbd177aa48f84035768cc23817950b9

Comment 7

[Dianna Smith [:diannaS]]

:kcochrane any update ? should we wontfix 154?

Comment 8

[Kelly Cochrane [:kcochrane]]

Yeah this P3, so we aren't working to get this fixed in 154

Comment 9

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2047653