2058050 - Default bookmarks link relies on early beta or earlier define

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[:Gijs (he/him)]

Bug 1805277 added some default bookmark change. I'm a little lost because the code currently looks like this:

https://searchfox.org/firefox-main/rev/4c201594e8be406786dd33b609429a29d5a10813/browser/base/content/default-bookmarks.html#36-40

#ifdef EARLY_BETA_OR_EARLIER
            <dt><a href="https://www.mozilla.org/contribute/?utm_medium=firefox-desktop&utm_source=bookmarks-toolbar&utm_campaign=new-users-beta&utm_content=-global" icon="@mozilla_icon@" data-l10n-id="default-bookmarks-firefox-community">default-bookmarks-firefox-community</a></dt>
#else
            <dt><a href="https://www.mozilla.org/contribute/" icon="@mozilla_icon@" data-l10n-id="default-bookmarks-firefox-community">default-bookmarks-firefox-community</a></dt>
#endif

which doesn't quite match the comments in bug 1805277.

Regardless, the define will stop working mid-august so we need to decide what to do here. Some standard options are outlined in bug 2051729, but others may be available.

Katherine, can you liaise with Ania and agree on how we want to move forward here?

Comment 1

[kpatenio]

Thanks for flagging this, Gijs. I'll reach out to Ania to decide on how to proceed.

Comment 2

[kpatenio]

I discussed with Ania, and we decided to defer any default bookmark UTM changes to post-Nova.

We rarely need to evaluate product vs. non-product traffic to these pages, so a single tag solution for beta/devEdition/release wouldn't be useful right now. We'd also like to rethink the utm campaign structure. The bookmarks were moved from the toolbar to the Bookmarks Menu, so the surface they live on has changed since the tags were set up. And lastly, Bookmarks are a potential area of work in our post-Nova roadmap, so it makes sense to revisit it then.

We're okay losing the utm_campaign=new-users-beta tag on early Beta and DevEdition (Nightly remains unaffected). For now, I'll remove EARLY_BETA_OR_EARLIER and make us fall back to the untagged https://www.mozilla.org/contribute/ link to avoid leaving unreachable code behind.

I will file a separate post-Nova follow-up for the utm campaign restructure.

Comment 3

[kpatenio]

Attachment: Bug 2058050 — remove EARLY_BETA_OR_EARLIER in default-bookmarks.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd53321bab7c
https://hg.mozilla.org/integration/autoland/rev/9f58fedd8ce6
— remove EARLY_BETA_OR_EARLIER in default-bookmarks.html r=Gijs

Comment 5

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/9f58fedd8ce6