Closed Bug 2058238 Opened 1 month ago Closed 23 days ago

12.12 - 2.27% tresize + 2 more (OSX, Windows) regression on Tue July 21 2026

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox154 --- unaffected
firefox155 --- fixed

People

(Reporter: performance-sheriff-bot, Assigned: Vincent)

References

(Regression)

Details

(4 keywords)

Attachments

(1 file)

Perfherder has detected a talos performance regression from push 6ce73127512654d7c24036bd8a39782e56eb88d2. As author of one of the patches included in that push, we need your help to address this regression.

Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

Regression Test Platform Options Absolute values [old vs new]
12% tresize (doc) macosx1470-64-shippable e10s fission stylo webrender 7.30 ms -> 8.18 ms
2% tp5n nonmain_normal_fileio (doc) windows11-64-25h2-shippable e10s fission stylo webrender-sw 564,302,216.54 -> 578,146,431.00
2% tp5n nonmain_normal_fileio (doc) windows11-64-25h2-shippable e10s fission stylo webrender 568,957,113.08 -> 581,868,324.00
Improvement Test Platform Options Absolute values [old vs new]
3% tresize (doc) linux1804-64-shippable-qr e10s fission nova stylo webrender 21.96 ms -> 21.26 ms
3% tresize (doc) linux1804-64-shippable-qr e10s fission stylo webrender 21.65 ms -> 21.08 ms

Support & Actionable Steps

For questions, please contact bacasandrei@mozilla.com. You can also find help on Slack (#perf-help) or Matrix (#perftest).

Action guide details:

Flags: needinfo?(bugzilla.mozilla.org)
Flags: needinfo?(bugzilla.mozilla.org)
Flags: needinfo?(bugzilla.mozilla.org)

Just a note that we're looking into this, but I'm still somewhat new to Firefox dev, and this is my first performance regression, so I'm still getting my bearings :)

r=#urlbar-reviewers

While technically, it's the size of the URL bar that matters, checking
that with a container query caused a performance regression (in the
tresize test on MacOS). Thus, we use a media query as a good-enough
proxy for URL bar width.

This PerfCompare run shows that it resolves the ~12% regression on
MacOS:
https://perf.compare/compare-lando-results?landoInstance=lando-prod-2025&baseLando=73863&newLando=73864&baseRepo=try&newRepo=try&framework=1

Assignee: nobody → bugzilla.mozilla.org
Attachment #9620627 - Attachment description: WIP: Bug 2058238 - Use a media query as a proxy for URL bar width. → Bug 2058238 - Use a media query as a proxy for URL bar width. r=#urlbar-reviewers
Status: NEW → ASSIGNED
Flags: needinfo?(bugzilla.mozilla.org)
Severity: -- → S3
Priority: -- → P2

Out of curiosity, when a new feature introduces a measurable performance regression (like the container query here), who ultimately decides whether the regression is acceptable versus requiring an alternative implementation? Is there an established process for making that tradeoff?

(In reply to Kaitlyn from comment #3)

Out of curiosity, when a new feature introduces a measurable performance regression (like the container query here), who ultimately decides whether the regression is acceptable versus requiring an alternative implementation? Is there an established process for making that tradeoff?

https://www.mozilla.org/about/governance/policies/regressions/ is the overview, though doesn't really make it clear (I believe it is generally on a per-team basis, but I don't know if the "owners" of the particular metrics should be involved). Probably worth asking in one of the perf-help channels.

Pushed by kandres@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cc6d9ebf3740 https://hg.mozilla.org/integration/autoland/rev/adf2310f5eb5 Use a media query as a proxy for URL bar width. r=urlbar-reviewers,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
QA Whiteboard: [search][qa-triage-done-c155/b154]
Regressions: 2063300
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: