2059330 - [Nova] Tab height with Touch density is not taller than Standard density

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[moriyama164]

Preconditions

• browser.nova.enabled is set to true.

Steps to reproduce

1. Open Customize Firefox page. E.g., click the application menu button (≡) → More tools → Customize toolbar…
2. Click the Window density settings link at the bottom of the Customize page (opens the Window density section on the Appearance settings page, about:preferences#appearance).
3. Click the Touch radio button.
4. Click the Standard radio button.
5. Repeat steps 3 and 4, and observe whether the tab height changes.

Actual results

• The tab height does not change.

Expected results

• When the density is set to Touch, the tab height should be greater than when it is set to Standard.

Tested on

• Gentoo Linux (KDE Plasma 6, X11)
• Windows 10 (VM in VirtualBox)

Regression range

• https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5d85334c95eda979785d121004aa4a8ee310deb4&tochange=cdabc42428fa68fd62d2c05537373e8ae409a194
• Regressed by: Bug 2023692

Comment 1

[Dão Gottwald [:dao]]

Thanks for filing! Does this require open tab groups or can you reproduce without?

Comment 2

[moriyama164]

(In reply to Dão Gottwald [:dao] from comment #1)

Thanks for filing! Does this require open tab groups or can you reproduce without?

It reproduces regardless of whether any tab groups are open.

Comment 3

[BugBot [:suhaib / :marco]]

:nsharpley, since you are the author of the regressor, bug 2023692, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Thanks for filing! I see the issue and will look into it.

Comment 5

[Stephen Thompson [:sthompson]]

Thanks for filing! We don't have a specific UX spec calling for a specific touch density size in the Nova redesign, but it makes sense to ensure there is more space in touch density.

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 2059330 - Update tab height for Touch density in Nova

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/622301521c8e
https://hg.mozilla.org/integration/autoland/rev/19e1ee37c838
Update tab height for Touch density in Nova r=desktop-theme-reviewers,tabbrowser-reviewers,jsudiaman,tgiles

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/19e1ee37c838