206055 - [XUL] <label>'s control attribute doesn't work

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[KENZ (Kenji Irie)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.4b) Gecko/20030517 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.4b) Gecko/20030517 Mozilla Firebird/0.6

Clicking <label> should focus the element associated by <label>'s control attribute.

Reproducible: Always

Steps to Reproduce:
1. create a element has id(i.e. id="test"), and create a <label> has control
attribute indicate that element id(control="test")
2. view the XUL file
3. click the label

Actual Results:  
element has id "test" isn't focused. and an error "controlElementID.focus is not
a function" is reported.

Expected Results:  
element has id "test" should be focused.

Comment 1

[KENZ (Kenji Irie)]

Attachment: patch for proposal

this contains fix for MozillaFirebird, too.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 123585 [details] [diff] [review]
patch for proposal

Please drop me a mail when this has review (and approval if you want to try to
get this in for 1.4) and I'll check it in for you... sr=me.

Comment 3

[KENZ (Kenji Irie)]

Thanks superreview, bzbarsky.

Requesting approval 1.4 final.
This patch fixes the problem that an typo broke the XUL <label> element's
control attribute. This must be safe to land, because this is small script typo
fix in xbl.

Comment 4

[KENZ (Kenji Irie)]

I'd mistaken sorry for bugspam.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 123585 [details] [diff] [review]
patch for proposal

a=sspitzer, once you get a review.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in the change to xpfe/.  I don't have cvs access to toolkit/; you will
need to get one of the following people to check that part in for you (and
probably review it too, for toolkit):

  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]
  [e-mail]

Most of them don't really read bugmail, so I suggest personal mail; Dean Tessman
or [e-mail] are your best bets, I think.

Comment 7

[:deanis74]

I'm out of town until Tuesday, but remind me if it's not checked in by then and
I'll do it.

Comment 8

[:deanis74]

I checked in the patch to toolkit.  Marking fixed.

Comment 9

[KENZ (Kenji Irie)]

Thanks checking in, dean. all reviews.

Comment 10

[[e-mail]]

*** Bug 128736 has been marked as a duplicate of this bug. ***