128736 - controlElementID.focus() should be controlElement.focus()

Status: VERIFIED DUPLICATE of bug 206055

(Core :: XUL, defect)

Description

[[e-mail]]

Comment 1

[[e-mail]]

Attachment: Proposed Patch

Comment 2

[Brendan Eich [:brendan]]

Should this go into 0.9.9?  How exactly does the bug bite, and how likely is
that reproduce-by case?

Nit: someone (not Neil) mixed 'if (' and 'if(' styles -- the latter badly. 
What's more, there's no need to test controlElement if !controlElementID:

        var controlElementID = this.getAttribute('control');
        if (controlElementID) {
          var controlElement = document.getElementById(controlElementID);
          if (controlElement)
            controlElementID.focus();
        }

/be

Comment 3

[Blake Ross]

I suggested that Neil file this, but I didn't look at what code the bug is in. 
I think this code should just be removed (I thought I had removed it already, in
fact.)  Clicking on a control with a control association doesn't focus the
associated control in Windows, so why should it in our app?

Comment 4

[[e-mail]]

Blake, bonsai fingered you last time I looked :-)
Perhaps this was added to correlate with the HTML <LABEL> element.

Comment 5

[jag (Peter Annema)]

If this is just for focusing a textbox when a label is clicked, then yeah, let's
remove this.

Comment 6

[Asa Dotzler [:asa]]

not an 0.9.9 blocker. 

Comment 7

[[e-mail]]

*** Bug 201939 has been marked as a duplicate of this bug. ***

Comment 8

[[e-mail]]

*** This bug has been marked as a duplicate of 206055 ***

Comment 9

[:deanis74]

v