Open Bug 2061236 Opened 3 months ago Updated 15 days ago

Load edit-mode date/time values

Categories

(Calendar :: Calendar Frontend, task)

task
Points:
3

Tracking

(Not tracked)

People

(Reporter: arschmitz, Unassigned)

References

(Depends on 1 open bug, Blocks 5 open bugs)

Details

(Whiteboard: [calendar-ui-create-edit])

Summary:
Copy the loaded event's dates and times into the draft before showing the
Date and time row. The draft holds unsaved values. Loading it must not change
the saved event.

Links:

Acceptance criteria:

  • Use only the loaded data accepted for the current edit operation. If
    recurrence-id identifies one occurrence, use that occurrence's values.
  • Copy dates, times, All-day or timed state, Multi-day state, and timezone IDs
    or names needed by the timezone controls.
  • Starting another load, changing the event, or closing the dialog prevents
    an earlier result from replacing the current values.
  • Finish copying values, or report the load failure, before show readiness
    completes. Initial content must not grow the dialog after positioning.
  • Loading and ordinary input leave the saved event unchanged. Only Save can
    apply changes to it.

Required implementation details:

  • Use the source snapshot: the plain data copy from the shared loader. Check
    its session ID, which identifies the current create or edit operation.
  • Include date/time mapping in the shared source-to-draft reset. Do not add
    another loader or a cache of live events.
  • Store serializable date/time values and flags only. Keep calIEvent,
    calIDateTime, live calendars, input elements, and editor objects outside Redux
    and the draft.
  • Render through stable storeObserver selections. Do not add getters that
    read the store directly.
  • Pass timezone values to Bug 2061579, which owns their display and interaction.

Minimum test coverage:

  • Check normal events and a selected occurrence of a repeating event.
  • Check All-day, timed, Multi-day, and timezone values.
  • Check that the draft contains no live platform objects.
  • Load A, switch to B, then finish A. Check that A cannot replace B's values.
    Also check closing the dialog during loading.
  • Check that mapping finishes or fails before show readiness completes.
  • Check that copying values does not change the source event.
  • Run axe checks on displayed edit states where supported.

Out of scope:

  • Implementing the shared draft model or source loader, and choosing defaults.
  • Date picker, time entry, timezone interaction, visibility, and enabling rules.
  • Validation, Calendar transactions, and saving.
Blocks: 2061240
Blocks: 2061244
Blocks: 2061579
Blocks: 2062087
Type: enhancement → task
Points: --- → 3
You need to log in before you can comment on or make changes to this bug.