Open
Bug 2061244
Opened 3 months ago
Updated 1 month ago
Implement time dropdowns and typed time override
Categories
(Calendar :: Calendar Frontend, task)
Calendar
Calendar Frontend
Tracking
(Not tracked)
NEW
People
(Reporter: arschmitz, Unassigned)
References
(Depends on 2 open bugs, Blocks 2 open bugs)
Details
(Whiteboard: [calendar-ui-create-edit])
Summary:
Let the user select or type start and end times. Check required dates and times
and show an error when the end is before the start. Keep changes in the draft,
which holds unsaved values.
Links:
- Zeplin time dropdown annotation: https://app.zeplin.io/project/66dd0f2b2fe8f1b63cda36f1/screen/6a0f2f285393a283202254bc
- Zeplin time/date dropdown variant: https://app.zeplin.io/project/66dd0f2b2fe8f1b63cda36f1/screen/6a0f4024757c26ac36daf58d
- Interaction guide: Create > Time: https://docs.google.com/document/d/15OpMthOHmBGyPpDBNRW8vp6uCxeoitBp8n7Fti3LD10/edit?tab=t.why4m6lqup0#heading=h.kvtn68hx95tv
- Planning: Select Menu - Suggested Implementation Slices
Acceptance criteria:
- Offer start and end times in 15-minute steps, beginning at 12:15 AM.
- Also accept any valid typed hour and minute. Use the user's 24-hour or AM/PM
time-format preference. - Hide time inputs for All-day events and show them for timed events.
- Require a start date. For timed events, also require start and end times.
- Allow an invalid range while the user is editing. When focus leaves the
control, show "Invalid time/date range" if the end is before the start.
Keep Save unavailable until the date/time values are valid. - Apply initial All-day visibility before positioning the dialog. Later
changes follow the existing layout and overflow rules, without unexpected
growth of the outer dialog. - After switching from event A to B, an old blur event, parsed value, or dropdown
selection from A must not change B's draft.
Required implementation details:
- Observe the current session's dates, times, and All-day state through stable
storeObserver selections. A session identifies one create or edit operation.
Do not add getters that read the store directly. - Keep unfinished typed text and dropdown-open state inside the control.
Once text parses as a time, send a typed update for the time section only,
using the draft's standard serializable format. - Keep calIDateTime, live calendars, input elements, and editor objects outside
Redux and the draft. - Publish errors through the shared date/time section validation state.
- Bugs 2061232 and 2061236 supply initial values; Bug 2061240 owns date selection.
This story owns time entry, dropdowns, and the range check after entry. - Clear local editing state when the current session changes.
Minimum test coverage:
- Check All-day visibility, 15-minute options, typed valid times, and both formats.
- Check unfinished text stays local and parsed values update only the time section.
- Check required dates/times, errors on blur, and Save remaining unavailable
while date/time validation fails. - Check initial visibility before positioning and later layout behavior.
- Switch from A to B and check that A's old input, blur, and selection do nothing.
- Check that Redux and the draft contain no live platform objects.
- Run axe checks on displayed time controls where supported.
Out of scope:
- Initial values, date picker behavior, timezone and recurrence controls.
- Implementing the shared draft model or Save transactions.
- Saving events.
| Reporter | ||
Updated•1 month ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•