Open Bug 2061582 Opened 3 months ago Updated 1 month ago

Implement custom recurrence editor

Categories

(Calendar :: Calendar Frontend, task)

task

Tracking

(Not tracked)

People

(Reporter: arschmitz, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [calendar-ui-create-edit])

Summary:
Let users edit a custom repeat schedule in the Repeat view. Keep related choices
consistent when a field changes. Store the rule in the draft, which holds
unsaved values, and apply it through Save.

Links:

Acceptance criteria:

  • Support Every, first/last weekday-based choices, weekday toggles, and end
    conditions of Never, On date, or After occurrences.
  • When an earlier field changes, update or reset the dependent fields below
    it in the same draft update. Changing a lower field must not change fields
    above it. Do not expose a partly updated rule between these changes.
  • Order weekday toggles using the user's first-day-of-week preference.
  • Edit only an already-active repeat rule. Bug 2061580 handles Add/Remove;
    Bug 2061581 handles preset choices.
  • After leaving Repeat or switching events, an old field action must not
    change the newer recurrence draft.
  • Save and reload the final rule through existing Calendar recurrence APIs
    without changing its meaning. Preserve existing recurrence behavior, Undo,
    Redo, and notifications.

Required implementation details:

  • Render stable storeObserver selections of the current session's active
    recurrence draft. A session identifies one create or edit operation.
    Do not add getters that read the store directly.
  • Calculate the changed field and any required dependent resets, then send
    one typed recurrence-section update containing all of them.
  • Store frequency, interval, weekday/position choices, end condition, end date,
    and occurrence count as plain serializable values. Keep live recurrence API
    objects, calIEvent, live calendars, input elements, and editors out of the draft.
  • Read week-start order from the platform preference; do not copy that preference
    into Redux.
  • Reject pending local actions after session replacement or leaving the view.
  • The field-owned Save serializer converts the plain rule through the existing
    recurrence APIs. The Save controllers perform the event transaction.

Minimum test coverage:

  • Check Every, first/last weekday choices, weekday toggles, and all end conditions.
  • Change an earlier field and check that dependent resets happen in one update.
    Change a lower field and check that earlier values stay unchanged.
  • Check weekday order for different week-start preferences.
  • Check plain recurrence data and no live platform objects in draft updates.
  • Leave Repeat or switch from A to B, then check that old field actions do nothing.
  • Save and reload custom rules; check their meaning, Undo, Redo, and notifications.
  • Run axe checks on displayed custom controls where supported.

Out of scope:

  • Basic Add/Remove, presets, and prompts about which occurrences to change.
  • Implementing the shared draft model.
  • Direct event changes or saving outside the create/edit Save transaction.
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.