2061633 - Undo no longer works in the address bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: undo option no longer works in the address bar

Affected versions

• Fx 155.0a1
• Fx 154.0b7o

Affected platforms

• Windows
• Ubuntu
• macOS

Steps to reproduce

1. Launch Firefox and focus the address bar.
2. Input any text in the address bar.
3. Right click the addres bar and choose 'undo'.

Expected result

• Undo option is available.

Actual result

• Undo option is grayed out. Keyboard shortcut is not working either.

Regression range

• First bad: 2026-07-09
• Last good: 2026-07-08
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3e6e3f4a1f86ceebb5f00a437e5356487ed9a10b&tochange=01cdb7386d49146050355a59fa002d346ac0ec91
• Potentially regressed by: bug 2022527.

Additional notes

• Same issue exists in the search bar as well.
• Other text boxes or text areas withing websites/pages are not affected.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2022527

:mbeier, since you are the author of the regressor, bug 2022527, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: example.html

That's probably the right regressor. The undo history is lost when toggling popover, so it only happens when the urlbar results panel closes, for example when opening the context menu. While it's open, ctrl+z works as expected.

You can use the attached example to test.

Emilio, could you have a look?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Masayuki is more familiar than me with the undo stack stuff. Do you have the cycles?

I think this is basically a dupe of bug 2017065 which seems unlikely to be a recent regression FWIW.

Comment 4

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox154 (beta) and tracked for firefox155 (nightly). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[CalebChan]

Do we know at what point this regression occurred?

Comment 6

[Moritz Beier [:mbeier]]

Attachment: Bug 2061633 - Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust browser_searchbar_new.js. r?#urlbar-reviewers

This reverts commit f19cee519d9c4a951986d8e96a5a7ee78be7e59a.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8accab4a4eb8
https://hg.mozilla.org/integration/autoland/rev/a8d6de1a5c5c
Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust browser_searchbar_new.js. r=urlbar-reviewers,dao

Comment 8

[Moritz Beier [:mbeier]]

Attachment: Bug 2061633 - Revert Bug 2022527 and fix an issue in browser_tokenAlias.js.

This reverts commit f19cee519d9c4a951986d8e96a5a7ee78be7e59a.

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes an S2 bug in the urlbar
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2061633#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Only reverts the patch that caused it
• String changes made/needed?: no
• Is Android affected?: no

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/94bdec29c080
https://hg.mozilla.org/releases/mozilla-beta/rev/e38f9a28f61a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4a1bbc602c2
https://hg.mozilla.org/integration/autoland/rev/0b9ae88bff23
Revert "Bug 2061633 - Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust browser_searchbar_new.js. r=urlbar-reviewers,dao" for causing failures at browser_startup_flicker.js.

Comment 12

[Atila Butkovits]

Backed out for causing failures at browser_startup_flicker.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b9ae88bff23

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C24.04%2Casan%2Copt%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux2404-64-asan%2Fopt-mochitest-browser-chrome-swr%2Cbc6&revision=a8d6de1a5c5cc7791b00b846ff03177a1a65e81a&selectedTaskRun=MA3RV30nT7CSnw7Rz34V2g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=584334633&repo=autoland&task=MA3RV30nT7CSnw7Rz34V2g.0&lineNumber=3075

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)

Masayuki is more familiar than me with the undo stack stuff. Do you have the cycles?

I think this is basically a dupe of bug 2017065 which seems unlikely to be a recent regression FWIW.

Yeah, I think so. I tried to fix it in H1 within a spare time, but it was hard to fix because the independent SelectionController is not safely managed by PresShell so that PresShell may be destroyed first and SelectionController causes UAF. I mean, I cannot fix it quickly. So, backing out it is reasonable.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Hi, 155 rode to Beta today. Am I understanding the history of this bug correctly that we attempted to back bug 2022527 out from 155 too only to hit test permafails that required it to be re-landed? What's the plan here? Reminder that 155 is our first Metronome release and only has 2 weeks of Beta before it ships, so this needs to be a high priority.

Comment 15

[Moritz Beier [:mbeier]]

Yes that's correct. the revert causes startup flicker on linux asan builds when nova is enabled. I'm currently working on a fix and will request uplift for 155 when it lands in nightly.

Comment 16

[Moritz Beier [:mbeier]]

Attachment: Bug 2061633 - Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust browser_searchbar_new.js.

This reverts commit f19cee519d9c4a951986d8e96a5a7ee78be7e59a.

Original Revision: https://phabricator.services.mozilla.com/D317572

Comment 17

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes an S2 bug in the urlbar
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2061633#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Only reverts the patch that caused it
• String changes made/needed?: no
• Is Android affected?: no

Comment 18

[Moritz Beier [:mbeier]]

Actually, it can already land in 155 because nova is disabled there.

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/315f5413afc6
https://hg.mozilla.org/releases/mozilla-beta/rev/927e4dbb89b0

Comment 20

[Moritz Beier [:mbeier]]

The startup flicker test fail with nova enabled is caused by the separate inactive window transitions as explained here: https://bugzilla.mozilla.org/show_bug.cgi?id=2063231#c7

I think the revert just messes with the timing a little bit and causes one of the transitions to happen in different frames on the asan build.
We could adjust the test or disable the transition on startup, but I think this will go away with bug 2063294.

Comment 21

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed for Fx 155.0b3 and Fx 154.0 RC on WIndows, macOS and Ubuntu. Undo works again correctly in the address bar for those builds.
Waiting for the nightly fix.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e766c55165a2
https://hg.mozilla.org/integration/autoland/rev/16420a18c0aa
Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust browser_searchbar_new.js. r=urlbar-reviewers,dao

Comment 23

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/16420a18c0aa

Comment 24

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed on Fx156.0a1 on Windows, macOS and Ubuntu. Undo works correctly in the address bar.

Comment 25

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #22)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e766c55165a2
https://hg.mozilla.org/integration/autoland/rev/16420a18c0aa
Revert Bug 2022527, fix an issue in browser_tokenAlias.js and adjust
browser_searchbar_new.js. r=urlbar-reviewers,dao

Perfherder has detected a talos performance change from push 16420a18c0aaa39974c59446ba53c33fbed23b23.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
14%	tp5o_scroll_paint_skip (doc)	linux2404-64-shippable	e10s fission stylo webrender-sw	0.95 -> 0.82
12%	tp5o_scroll (doc)	linux2404-64-shippable	e10s fission stylo webrender-sw	2.19 -> 1.92

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.