2062663 - <notification-message> close button isn't centered on Nova

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: hovered close button

The notification button doesn't seem to be centered. This is more visible when the button is hovered.
Looks similar to the issue we had for preference dialog in Bug 2054029

Comment 1

[Hanna Jones [:hjones]]

We used to have some clever CSS logic for ensuring that the icon, text, and close button were all vertically aligned properly: https://searchfox.org/firefox-main/rev/78cec12077df51c8f48b8a485a825b446f0c6d02/toolkit/content/widgets/moz-message-bar/moz-message-bar.css#48

It looks like that got lost in the shuffle of making Nova style changes, likely the fix here is just to bring it back rather than relying only on Flexbox. Likely it'll make sense to just fix this in bug 2054561.

Comment 2

[akulyk]

Could you please clarify whether this bug is about centering the close icon within the button, or centering the button within its container? Thanks!

Comment 3

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: close button

(In reply to akulyk from comment #2)

Could you please clarify whether this bug is about centering the close icon within the button, or centering the button within its container? Thanks!

sorry, my wording wasn't accurate enough. I mean the close icon is not properly horizontally centered within the button (see screenshot)

Comment 4

[akulyk]

Attachment: Bug 2062663 - close icon isn't centered on Nova r=#recomp-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16ccbf4657a0
https://hg.mozilla.org/integration/autoland/rev/f6284e2103bf
close icon isn't centered on Nova r=desktop-theme-reviewers,jules

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/f6284e2103bf