2062707 - Thunderbird: Enable and require phabricator reviews for uplift requests

Status: NEW

(Conduit :: Lando, enhancement, P3)

Description

[Evandro Baginski [:ebaginski]]

We would like to add the ability to request uplifts through phabricator for Thunderbird. Currently, only Firefox is available as target in Lando when requesting uplifts. Thanks.

Comment 1

[Connor Sheehan [:sheehan]]

Scope

There a quite a few Firefox-only assumptions baked into the uplift automation workflow at the moment, enough that it's not as trivial as "enable Thunderbird". Before moving forward, it would be good to know which pieces of the workflow you want specifically (fully matching Firefox is acceptable too). A short summary of the pieces:

• Devs use moz-phab uplift or Lando to request uplift to an uplift target. When initiated from Lando, they can select the Firefox version they want their uplift to target (pulled from whattrainisitnow.com). This creates a new Phabricator revision targeting the uplift train (for Firefox this is beta/release/esr*).
• Devs complete the uplift assessment form and link it to the new revision in Lando. Once completed the form is posted to Phabricator and displayed in the "Details" section at the top of the revision page.
• phab-bot automation in BMO sees the uplift form on the Phab revision and requests blocking review from the #release-managers Phab group.
• Release managers use a dashboard in Phab to view the pending uplift revisions, read the uplift assessment form on the revision page and approve/decline to uplift revisions. RelMan then lands the changes via Lando. Lando has a blocker which prevents landing revisions without #release-managers group approval.
• At landing time, Lando updates the appropriate tracking flags in BMO by parsing the version from config/milestone.txt.

OTOMH we will need to:

• Update the workflow to differentiate between uplifts targeting Thunderbird vs Firefox. We'll need to update the approval_required flag to instead be a reference to the autoland branch for each project. We'll need to do this in both Lando and moz-phab.
• Update the version-selection widget to not display for Thunderbird, or hook in the Thunderbird equivalent of whattrainisitnow.com.
• Update the phab-bot logic in BMO to account for Thunderbird changes.

Questions

• Is there an equivalent to the #release-managers group in Phab for Thunderbird?
• Which comm- branches are uplift targets? -beta, -release, -esr140?
• Is the uplift assessment form okay to re-use for Thunderbird? There are some Firefox specific questions like "Is Android affected?" and "Fix verified in nightly?". Avoiding re-implementation here would be ideal.
• Do we have BMO tracking fields that are equivalent to cf_status_firefox{milestone} or can we forego updating tracking flags for Thunderbird?
• Where does comm-central keep the version of the tree (ie the equivalent of config/milestone.txt)?

Comment 2

[Evandro Baginski [:ebaginski]]

Thanks Connor, I'm working on getting the info you've requested and will get back to you shortly.

Comment 3

[Evandro Baginski [:ebaginski]]

Here's the info:

• Not at the moment, but I've asked Corey to create it. We've created a #thunderbird-release-managers.
• Does it have to match what we have in Lando? If so, it's thunderbird-desktop-beta/release/esr140/esr153. If it doesn't have to match and you do the mapping on your end, it could be thunderbird-beta/release/esr140/esr153.
• Ours is a little different (example bug: 2058141):

Uplift Approval Request
    Please state case for uplift consideration and ensure bug severity is set: 
    User impact if declined: 
    Is this code covered by automated tests?:
    Has the fix been verified in Daily?:
    Has the fix been verified in Beta?:
    Needs manual test from QA?:
    If yes, steps to reproduce:
    List of other uplifts needed:
    Risk to taking this patch:
    Why is the change risky/not risky? (and alternatives if risky): 
    Does the fix cause any migrations to be skipped?: 
    String changes made/needed:

• We do have tracking flags, which can be seen by editing the aforementioned bug (2058141): thunderbird_esr140 thunderbird_esr153 thunderbird153 thunderbird154 thunderbird155 thunderbird156
• In mail/config/version.txt.

Will let you know as soon as we get the #release-managers` group created. Please let me know if anything else is required. Thanks!

Comment 4

[Evandro Baginski [:ebaginski]]

Hi Connor, sorry for the delay. We now have a #thunderbird-release-managers that we can use for the purpose of this. Thanks for your help.