2063470 - [Tab Groups] [Page Level Add to Group] Add the "Add to Group"/"Move to Group" item to the Menu

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, task)

Description

[Julie De Lorenzo [:jdelorenzo]]

This ticket tracks adding the menu item to the menu:

• Different text based on whether or not the active tab is in a group
• Fetching the group tab mapping data to determine the text
• Has the "new" badge and circle indicator, see Figma: https://www.figma.com/design/iBmi6I1Q2oSXqJMjguOfwb/Tab-Groups-Android?node-id=22334-14015&p=f&m=dev. See the "Phase 2" page and "Page level add to group"

Comment 1

[Julie De Lorenzo [:jdelorenzo]]

This should

Comment 2

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 part 2: Add the "Add to Group"/"Move to Group" item to the Menu

Comment 3

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 part 3: Add the snackbar to the menu actions

Comment 4

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 part 4: Hook up storage actions

Comment 5

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 part 1: Remove the "New" indicator from the Summarize page menu item

Comment 6

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 part 5: Highlight the tab group menu item and toolbar menu button for feature discovery r?petru,#android-tabs-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31073cce659e
https://hg.mozilla.org/integration/autoland/rev/e37e2ce1903d
part 1: Remove the "New" indicator from the Summarize page menu item r=android-reviewers,sfamisa,007
https://github.com/mozilla-firefox/firefox/commit/48ca6870ffc4
https://hg.mozilla.org/integration/autoland/rev/c1c0db60c46b
part 2: Add the "Add to Group"/"Move to Group" item to the Menu r=android-reviewers,android-l10n-reviewers,android-tabs-reviewers,petru,parker,007
https://github.com/mozilla-firefox/firefox/commit/643fbf9041be
https://hg.mozilla.org/integration/autoland/rev/6325c03999f5
part 3: Add the snackbar to the menu actions r=android-reviewers,android-l10n-reviewers,android-tabs-reviewers,parker,007
https://github.com/mozilla-firefox/firefox/commit/2d000acda636
https://hg.mozilla.org/integration/autoland/rev/ad6774037d8c
part 4: Hook up storage actions r=android-reviewers,android-tabs-reviewers,007
https://github.com/mozilla-firefox/firefox/commit/d5d1b01886fc
https://hg.mozilla.org/integration/autoland/rev/fc0f4e8f91c8
part 5: Highlight the tab group menu item and toolbar menu button for feature discovery r=petru,android-tabs-reviewers,android-reviewers,007

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e37e2ce1903d
https://hg.mozilla.org/mozilla-central/rev/c1c0db60c46b
https://hg.mozilla.org/mozilla-central/rev/6325c03999f5
https://hg.mozilla.org/mozilla-central/rev/ad6774037d8c
https://hg.mozilla.org/mozilla-central/rev/fc0f4e8f91c8

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e37e2ce1903d
https://hg.mozilla.org/mozilla-central/rev/c1c0db60c46b
https://hg.mozilla.org/mozilla-central/rev/6325c03999f5
https://hg.mozilla.org/mozilla-central/rev/ad6774037d8c
https://hg.mozilla.org/mozilla-central/rev/fc0f4e8f91c8

Comment 10

[Julie De Lorenzo [:jdelorenzo]]

Attachment: Bug 2063470 - Make tab groups menu secret setting visible in nightly

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9aaa6f195f27
https://hg.mozilla.org/integration/autoland/rev/8603d5c36401
Make tab groups menu secret setting visible in nightly r=android-reviewers,calu

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8603d5c36401