Open
Bug 2091560
Opened 4 days ago
Updated 1 day ago
Tab groups toolbar menu highlight does not update when the tab groups menu setting is toggled
Categories
(Firefox for Android :: Tabs, task)
Tracking
()
ASSIGNED
People
(Reporter: jdelorenzo, Assigned: jdelorenzo)
References
Details
(Whiteboard: [fxdroid][android-core][bugzilla])
Attachments
(1 external file)
FenixTabGroupsFeatureDiscoveryConfiguration.toolbarMenuButtonHighlight reads showMenuItem (showTabGroupsInMenu) inside a map over the repository's uiState, so it is only re-evaluated when the repository emits.
- Turning the setting off while the menu button is highlighted keeps the highlight for the rest of the session, since every repository write is gated on
showMenuItem. - Turning it on shows no highlight until the next repository write or restart.
Fix: observe the setting as a flow and combine it, as Summarize does with isFeatureEnabled.
Split from bug 2063470.
|
Assignee | |
Updated•4 days ago
|
Whiteboard: [fxdroid][android-core][bugzilla]
|
||
Updated•4 days ago
|
|
|
Assignee | |
Comment 1•1 day ago
|
||
|
||
Updated•1 day ago
|
Assignee: nobody → jdelorenzo
Status: NEW → ASSIGNED
You need to log in
before you can comment on or make changes to this bug.
Description
•