2064554 - Port bug 2053455 - Add support for multiple arguments in jump list items - TypeError: 'arguments' member of WindowsJumpListShortcutDescription can't be converted to a sequence. - WindowsJumpLists.sys.mjs:129:27

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Helge H.]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

Start TB 153.0.3 ESR.

Actual results:

Console error:
TypeError: 'arguments' member of WindowsJumpListShortcutDescription can't be converted to a sequence. WindowsJumpLists.sys.mjs:129:27

Expected results:

No console error.

Comment 1

[Magnus Melin [:mkmelin]]

Thanks for reporting, we seem to have missed porting bug 2053455 - https://hg.mozilla.org/mozilla-central/rev/955d237915be

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 2064554 - Port bug 2053455 - Add support for multiple arguments in jump list items. r=#thunderbird-reviewers

Port https://hg.mozilla.org/mozilla-central/rev/955d237915be

Comment 3

[Magnus Melin [:mkmelin]]

Not a sec issue for Thunderbird.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d7507fc45453
Port bug 2053455 - Add support for multiple arguments in jump list items. r=aleca

Comment 6

[Helge H.]

Attachment: taskbar-spinner.png

Thanks. In current Daily the console error is gone, but the jumplist still doesn't work. There's a little spinner that disappears eventually, but no menu items are added to the menu.

Comment 7

[Magnus Melin [:mkmelin]]

Seems you're hitting some other bug then. It apparently works in the normal case.
Please file a new bug with more details.

Comment 8

[Helge H.]

Normal case? Ah, talking to AI, there's an installation aspect to it, I was just running the executable without installation.

Comment 9

[Toby Pilling [:tobyp]]

Attachment: daily-jumplist-20260820.png

Hi Helge,
When do you see the little spinner? Is that displayed as soon as you right-click on Thunderbird in your taskbar? Or after clicking on one of the jumplist items?

I can't see the context of the spinner to understand what's happening but the changes Magnus made seem to work for me on Windows. If you report this as a separate issue, can you provide a bit more context so we can understand whether your profile is in a state that would allow you to perform the jumplist actions?

• Write new message
• Open address book work

Comment 10

[Toby Pilling [:tobyp]]

Yes without installation and a valid profile to perform the actions, they won't be available. All the best

Comment 11

[Helge H.]

In fact, it has nothing to do with installation. I'm running Windhawk with the "Taskbar classic context menu" mod. That does its own thing in the context menu and breaks the jumplist, for both TB and FF.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9628188 [details]
Bug 2064554 - Port bug 2053455 - Add support for multiple arguments in jump list items. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: m-c counterpart was uplifted everywhere
  While not a sec issue for Thunderbird, we get a broken jump menu due to the change.
• User impact if declined: Jump menu broken
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small porting change.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 13

[Corey Bryant]

Comment on attachment 9628188 [details]
Bug 2064554 - Port bug 2053455 - Add support for multiple arguments in jump list items. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for esr140
Approved for esr153

Comment 14

[Stephen King (:sking)]

Thunderbird 155.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/545916c8283e

Comment 15

[Corey Bryant]

Thunderbird 140.15.0esr:
https://hg.mozilla.org/releases/comm-esr140/rev/b2f02418c01e

Comment 16

[Corey Bryant]

Thunderbird 153.2.0esr:
https://hg.mozilla.org/releases/comm-esr153/rev/1d1661573eaf