Closed Bug 2066091 Opened 19 days ago Closed 19 days ago

Dismissible Sync promo on App Menu shows even if sync is disabled

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox154 --- unaffected
firefox155 --- fix-optional
firefox156 --- fix-optional

People

(Reporter: mkaply, Unassigned)

References

(Regression)

Details

(Keywords: regression)

A new sync promo was added in bug 2057674.

This shows even if sync is disabled.

It should honor the identity.fxaccounts.enabled preference.

Bug 2057674 applies to App Menu > History but another similar promo gets also displayed on App Menu > Bookmarks
Both should honor , identity.fxaccounts.enabled

Set release status flags based on info from the regressing bug 2057674

:skhamis, since you are the author of the regressor, bug 2057674, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox154: --- → unaffected
status-firefox155: --- → affected
status-firefox156: --- → affected
status-firefox-esr140: --- → unaffected
status-firefox-esr153: --- → unaffected
Flags: needinfo?(skhamis)
See Also: → 2065899

Not a blocking issue, as this is highly unlikely to impact a majority of users.

status-firefox155: affected → fix-optional
status-firefox156: affected → fix-optional
See Also: → 2062272

I verified that both these promos do honor if sync is disabled.

They use getSyncPromoState

https://searchfox.org/firefox-main/source/browser/base/content/browser-sync.js#1149

The bigger question is why Romain is seeing them in Firefox Enterprise when sync is enabled?

Separate issue.

Status: NEW → RESOLVED
Closed: 19 days ago
Resolution: --- → WORKSFORME
Flags: needinfo?(skhamis)
You need to log in before you can comment on or make changes to this bug.