2066252 - Prevent save if keyword checkin-needed-tb exists without target milestone

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement, P2)

Description

[Toby Pilling [:tobyp]]

Thunderbird has no sheriff automation that allows us to easily set Metadata on bugs when they land.

Could we please add some validation rule that prevents save if the checkin-needed-tb keyword is added without a target milestone being selected? Can be just within Thunderbird, mailnewscore and calendar.

Comment 1

[David Lawrence [:dkl]]

It is possible to do as we have some other similar special rules that block certain actions https://github.com/mozilla/bmo/tree/master/extensions/MozChangeField/lib/Pre. We would just create another module there specific to bugs in the Thunderbird, etc. product

Comment 2

[Toby Pilling [:tobyp]]

Oh cool, thanks! Would that be something that my team could/should do, or are there folks who can whip it together quicker?

Comment 3

[BMO Github Automation]

Attachment: [mozilla/bmo] Bug 2066252 - Require a target milestone when adding checkin-needed-tb (#2733)

Comment 4

[Toby Pilling [:tobyp]]

I got some help with this:
https://github.com/mozilla/bmo/pull/2733

Comment 5

[BMO Github Automation]

Attachment: [mozilla/bmo] Bug 2066252 - Prevent save if keyword checkin-needed-tb exists without target milestone (#2734)

Comment 6

[Toby Pilling [:tobyp]]

Do I need to remove my patch from here somehow?

Comment 7

[David Lawrence [:dkl]]

(In reply to Toby Pilling [:tobyp] from comment #6)

Do I need to remove my patch from here somehow?

We can just obsolete it. No problem.

Comment 8

[BMO Github Automation]

Authored by https://github.com/dklawren
https://github.com/mozilla/bmo/commit/5bd9270a330885fc75c5525bdca016f4431208a4
[master] Bug 2066252 - Prevent save if keyword checkin-needed-tb exists without target milestone

Comment 9

[Toby Pilling [:tobyp]]

Hi David,
Will this kick in immediately? I tested it with Bug 2058531 but it didn't seem to prevent me from saving without a target milestone.

Comment 10

[David Lawrence [:dkl]]

(In reply to Toby Pilling [:tobyp] from comment #9)

Hi David,
Will this kick in immediately? I tested it with Bug 2058531 but it didn't seem to prevent me from saving without a target milestone.

Not yet. It has just been merged to master. We still need to do a deployment for the change to show up in prod. Hopefully today, but if not then first of next week.

Comment 11

[Toby Pilling [:tobyp]]

Aha perfect, thanks. I'll be patient and check again next week!