2067593 - Opening "quick find" by typing "/" only works after using Ctrl-f once

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Frank Steiner]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:153.0) Gecko/20100101 Firefox/153.0

Steps to reproduce:

After clicking into a message body in TB 140esr pressing the slash "/" opens the "quick find" field where I can search text in the message body. In TB 153esr (and 153.0.4) the slash does nothing when pressed after restarting thunderbird.
But after opening the "Find in page" dialog by Ctrl-f once, the slash will then open the "quick find" for any message body until TB is restarted.
So every time after restarting TB 153, opening the quick find dialog by pressing the slash must first be enabled by using Ctrl-f and will then work for the rest of the session.
I guess it's a bug as I don't see any reason why a shortcut key should only work after using another shortcut once...?

Comment 1

[Martin Giger [:freaktechnik]]

This is "manual FAYT (find as you type)". In theory this should be hooked up through the FindBar actors. https://searchfox.org/comm-central/rev/c1db9bdfbcd3a44a655f9b340e1f6301363395a5/mail/components/MailGlue.sys.mjs#146-169

However I can reproduce it not working in messages, or any of the browsers in the 3pane for that matter. We might be capturing key events in a way that they never reach the actor?

Comment 2

[Wayne Mery (:wsmwk)]

Alice can you find the regression?

Comment 3

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=dd571ec2d7a1de40eaccb14baaabaa999293d6a6&tochange=38dc812a20d67b04e902e3aced0b0e9f52c183c1
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=af81f8120affd1393e4f37b024cae88a2429fa74&tochange=dca1688c7da6e3af526a4212b185539a42f859e2

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2067593 - Materialize the lazy findbar for manual FAYT. r=#thunderbird-reviewers

Register lazy findbars with the FindBar actor as proxies so pressing / can
materialize and use the findbar before Ctrl-F has been pressed. The wrapper only
registers while no real findbar exists, and retries once on the first browser
load for browsers that have no window global yet, so it never shadows the
findbar's own registration.

Add browser test coverage for opening quick find with / as the first find
shortcut.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6e2c072c3417
Materialize the lazy findbar for manual FAYT. r=mkmelin